Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing parameters for request #39

Merged
merged 4 commits into from
Dec 8, 2015
Merged

Missing parameters for request #39

merged 4 commits into from
Dec 8, 2015

Conversation

murnieza
Copy link
Contributor

@murnieza murnieza commented Dec 8, 2015

Closes #34

@murnieza murnieza added the qa label Dec 8, 2015
@saimaz
Copy link
Member

saimaz commented Dec 8, 2015

Please add also a docs for those changes.

@saimaz
Copy link
Member

saimaz commented Dec 8, 2015

It could be a new chapter about how to add parameters to query string or inside query. If there is not ready one.

@murnieza
Copy link
Contributor Author

murnieza commented Dec 8, 2015

Documentation added.

saimaz added a commit that referenced this pull request Dec 8, 2015
@saimaz
Merge pull request #39 from murnieza/query_params
8b394db 
Missing parameters for request
@saimaz saimaz merged commit 8b394db into ongr-io:master Dec 8, 2015
@saimaz saimaz removed the qa label Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murnieza @saimaz