Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display public key on "save address" (set slot) screen #13

Open
psiemens opened this issue Nov 10, 2020 · 2 comments
Open

Display public key on "save address" (set slot) screen #13

psiemens opened this issue Nov 10, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@psiemens
Copy link
Contributor

psiemens commented Nov 10, 2020

When saving a new address to the device, the "Set Slot" verification screen currently only shows the Flow address value, but it should also display the associated public key for that path.

This allows the user to check both the address and public key against an on-chain source in order to verify that they are paired correctly.

@psiemens psiemens added the bug Something isn't working label Nov 10, 2020
@psiemens psiemens self-assigned this Nov 10, 2020
@psiemens psiemens changed the title Display public key on address verification screen Display public key on "save address" (set slot) screen Nov 12, 2020
relatko pushed a commit that referenced this issue Apr 26, 2022
@pgebheim
Copy link

pgebheim commented Jul 12, 2022

@relatko Did your commit earlier in 0c7f4dd fix this issue or was that just related to this issue?

@relatko
Copy link
Contributor

relatko commented Jul 13, 2022

@pgebheim The commit was just rollback commit. Set slot path still does not show public key, just derivation address. See snapshots from current master:
https://github.com/onflow/ledger-app-flow/tree/master/tests_speculos/test-basic-slot-status-full

What however has been done is that if an address is stored on slot 0, then both getPublicKey call and an item in the menu allow to review both address and public key. To see how this interaction work at the moment you can review these snapshots
https://github.com/onflow/ledger-app-flow/tree/master/tests_speculos/test-menu

If the functionality as described here is still desired it is fairly straightforward task requiring one to two days of work (it may be slightly harder than it looks at the first glance, but still fairly easy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants