Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cadence v0.14.5, Go SDK v0.17.0, and Flow Go v0.15.3-patch.5 #6

Merged
merged 5 commits into from
Apr 14, 2021

Conversation

turbolent
Copy link
Member

Description

Update to the latest versions, which are currently deployed on Testnet and Mainnet


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested review from 10thfloor and psiemens April 13, 2021 00:37
@turbolent turbolent self-assigned this Apr 13, 2021
@@ -59,5 +59,4 @@ check-headers:

.PHONY: check-tidy
check-tidy: generate
go mod tidy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did this go? Shouldn't check-tidy run go mod tidy?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unfortunately breaking CI right now, see 99designs/gqlgen#1483: The go generate steps requires entries in go.sum, and reports errors if they are missing. go mod tidy then removes them. So it is currently impossible to commit code that satisfies both

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

compute/errors.go Outdated Show resolved Hide resolved
@turbolent turbolent merged commit a835801 into master Apr 14, 2021
@turbolent turbolent deleted the bastian/cadence-v0.14 branch April 14, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants