Fix session bug caused by [email protected] #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jribbink
commented
Nov 15, 2023
| @@ -170,7 +171,6 @@ func main() { | |||
|
|
|||
| r.Use(httpcontext.Middleware()) | |||
| r.Use(sessions.Middleware(cookieStore)) | |||
| r.Use(monitoring.Middleware()) | |||
There was a problem hiding this comment.
the middleware is already called here https://github.com/onflow/flow-playground-api/pull/347/files#diff-78f42ba40d0f10b08c73b7e6bb8376f398e249c963cf549e89591d6b6826b9a4R113
sideninja
approved these changes
Nov 15, 2023
chasefleming
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #348
Description
v2.1.9 of the playground API is not working in staging. I have debugged this and determined that the sentry update that was mandatory as a part of updating to the latest version of Cadence was responsible. It broke the session middleware
Namely, it has to do with how sentry affects the request context when being run twice in the middeware stack. Sentry stores the current transaction in the context & if one exists already, then it uses this transaction. However, this causes the request context to get rolled back to where it was during the first middleware call -> effectively removes any middleware values set between sentry middleware calls.
TL;DR this PR removes a redundant sentry middleware that was breaking the Playground. I also removed gorilla/mux because we aren't using it and it was just being used for a type.
For contributor use:
Files changedin the Github PR explorer