Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting commit on master to v0.18 for tomorrow's canary fix #841

Closed
wants to merge 1 commit into from

Conversation

vishalchangrani
Copy link
Contributor

@vishalchangrani vishalchangrani commented Jun 15, 2021

Fix from this PR ported over to brach v0.18

git cherry-pick 934f8b122ccf3553b866c54a3fc036072be426f1

@vishalchangrani vishalchangrani requested review from Kay-Zee and removed request for yhassanzadeh13 June 15, 2021 20:11
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v0.18@10ca730). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 934f8b1 differs from pull request most recent head 00baa6d. Consider uploading reports for the commit 00baa6d to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##             v0.18     #841   +/-   ##
========================================
  Coverage         ?   56.53%           
========================================
  Files            ?      427           
  Lines            ?    25112           
  Branches         ?        0           
========================================
  Hits             ?    14196           
  Misses           ?     9000           
  Partials         ?     1916           
Flag Coverage Δ
unittests 56.53% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10ca730...00baa6d. Read the comment docs.

@vishalchangrani
Copy link
Contributor Author

Closing PR - fix not needed on this branch as the Canary 5.5 will be off of current master which already has this change.

@vishalchangrani vishalchangrani deleted the vishal/v_0_18_with_fix branch June 16, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants