Copy slice when setting block hash list

[janezpodhostnik]

Solves the block hash list issue seen in #6552

The writing to the bucket was done in a way where the original value of the bucket was also changed. Later when we were checking if there are changes, the original bucket and the new bucket were the same so no changes were written.

This requires an HCU

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.24%. Comparing base (edf27b0) to head (755ec67).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6734   +/-   ##
=======================================
  Coverage   41.23%   41.24%           
=======================================
  Files        2054     2054           
  Lines      182364   182368    +4     
=======================================
+ Hits        75204    75219   +15     
+ Misses     100859   100852    -7     
+ Partials     6301     6297    -4     

Flag	Coverage Δ
unittests	41.24% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[zhangchiqing]

Suggested change

	cpy := make([]byte, len(bucket))
	copy(cpy, bucket)
	if err != nil {
	return err
	}
	if err != nil {
	return err
	}
	cpy := make([]byte, len(bucket))
	copy(cpy, bucket)

[m-Peter]

Good point, we can perform the bucket copy, after we know there's no error.

[zhangchiqing]

Do we have a test case that would fail without the fix and pass after the fix?

[janezpodhostnik]

@zhangchiqing Added a test in 291d0ca