[v0.32] [DO NOT MERGE] Validate the EpochSetup parsing is backward-compatible with extra fields
#5013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixtures include TargetEndTime
- includes change to add TargetEndTime to EpochSetup
jordanschalm
changed the title
EpochSetup parsing is backward-compatible with extra fieldsEpochSetup parsing is backward-compatible with extra fields
This was referenced Nov 14, 2023
jordanschalm
requested review from
gomisha and
yhassanzadeh13
as code owners
yhassanzadeh13
approved these changes
Nov 14, 2023
joshuahannan
approved these changes
Nov 15, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.32 #5013 +/- ##
==========================================
- Coverage 55.84% 52.96% -2.88%
==========================================
Files 945 754 -191
Lines 88208 68098 -20110
==========================================
- Hits 49257 36068 -13189
+ Misses 35241 29313 -5928
+ Partials 3710 2717 -993
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jordanschalm
changed the title
EpochSetup parsing is backward-compatible with extra fieldsEpochSetup parsing is backward-compatible with extra fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports over service event fixture changes and pins new contract version to validate that
v0.32is backward-compatible.it turns out that we do not need a patch upgrade on
v0.32. However, we should still merge this so that[email protected]uses the same smart contract and service events as will be present on live networks once we deploy onflow/flow-core-contracts#395.TODO
TargetDurationto Epoch models and API #4987 #5038core-contractspin to tagged version, once merged