Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] disable threadcreate profiler #2898

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Conversation

SaveTheRbtz
Copy link
Contributor

It has been broken since 2013. Verified on localnet and removed.

It is broken since 2013[1]. Verified on localnet.

[1] golang/go#6104
@SaveTheRbtz
Copy link
Contributor Author

bors merge

@codecov-commenter
Copy link

Codecov Report

Merging #2898 (ef2fb8e) into master (bc69bde) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2898      +/-   ##
==========================================
- Coverage   56.87%   56.87%   -0.01%     
==========================================
  Files         690      690              
  Lines       62662    62661       -1     
==========================================
- Hits        35642    35641       -1     
  Misses      24072    24072              
  Partials     2948     2948              
Flag Coverage Δ
unittests 56.87% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
module/profiler/profiler.go 85.00% <100.00%> (-0.15%) ⬇️
fvm/handler/contract.go 88.59% <0.00%> (-1.35%) ⬇️
engine/consensus/compliance/core.go 76.51% <0.00%> (ø)
consensus/hotstuff/eventloop/event_loop.go 74.82% <0.00%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc69bde...ef2fb8e. Read the comment docs.

@bors
Copy link
Contributor

bors bot commented Jul 29, 2022

Build succeeded:

@bors bors bot merged commit 03634c1 into master Jul 29, 2022
@bors bors bot deleted the rbtz/disableThreadCreate branch July 29, 2022 22:50
@SaveTheRbtz SaveTheRbtz changed the title [Profile] disable threadcreate profiler [Performance] disable threadcreate profiler Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants