-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLIP 204] Add targetDuration
to EpochSetup
#396
Merged
jordanschalm
merged 5 commits into
access-slots
from
jordan/394-add-duration-to-epochsetup
Nov 20, 2023
Merged
[FLIP 204] Add targetDuration
to EpochSetup
#396
jordanschalm
merged 5 commits into
access-slots
from
jordan/394-add-duration-to-epochsetup
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to compute tau, the steady-state optimal time/view, in the cruise control system
joshuahannan
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ready to merge?
joshuahannan
added a commit
that referenced
this pull request
Nov 21, 2023
…nd `EpochStart` event (#379) * adds performance improvements to end of epoch operations * construct proposed list within endStakingAuction * make ci * add first draft of open node slots code * adds automatic open access node slots and a test * add epoch start event * make ci * address PR comments * use borrow for storage instead of load * use borrow for more operations * address PR comments * use .remove * add timing config struct * add getter/setter, target time getter * update constructor * add transactions * begin test updates * add precondition that ref epoch in the past guarantees time computation doesn't underflow * add config update tests * rm unused method * test getting future epoch target end time * adds performance improvements to end of epoch operations * construct proposed list within endStakingAuction * make ci * add first draft of open node slots code * adds automatic open access node slots and a test * add epoch start event * make ci * address PR comments * use borrow for storage instead of load * use borrow for more operations * address PR comments * use .remove * add epoch counter arguments to rewards and new epoch events * [FLIP 204] Add `targetDuration` to `EpochSetup` (#396) * add duration to EpochSetup This is needed to compute tau, the steady-state optimal time/view, in the cruise control system * update generated files * update tests * tidy * tidy * add duration to refTimestamp * make ci --------- Co-authored-by: Jordan Schalm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows from #395, adding one additional piece of data which is required for Cruise Control.
FlowEpoch
on Canary again once this is merged