Fix LockedTokens reference expression #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolent
approved these changes
Jul 19, 2022
6 tasks
joshuahannan
approved these changes
Jul 19, 2022
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Jul 26, 2022
2823: [All] OpenTracing to OpenTelemetry migration r=SaveTheRbtz a=SaveTheRbtz Issue: #2796 OpenTracing spec is deprecated: opentracing/specification#163. Switching to the supported OpenTelemetry implementation. Note that new tracing code would honor [OTEL env vars](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.12.0/specification/protocol/exporter.md) instead of JAEGER ones, e.g.: `JAEGER_ENDPOINT` -> `OTEL_EXPORTER_OTLP_TRACES_ENDPOINT`, `OTEL_EXPORTER_OTLP_TRACES_INSECURE`, etc (cc: `@sjonpaulbrown` `@haroldsphinx)` New API is slightly slower and consumes more memory but does substantially less allocs (~ -50%): ``` name old time/op new time/op delta StartSpanFromParent-8 485ns ± 6% 639ns ± 1% +31.71% (p=0.000 n=10+9) StartTransactionSpan/cacheHit-8 993ns ± 4% 927ns ± 3% -6.69% (p=0.000 n=10+10) StartTransactionSpan/cacheMiss-8 2.24µs ± 1% 2.19µs ± 1% -2.42% (p=0.000 n=10+10) name old alloc/op new alloc/op delta StartSpanFromParent-8 577B ± 0% 864B ± 0% +49.74% (p=0.000 n=10+10) StartTransactionSpan/cacheHit-8 776B ± 1% 944B ± 0% +21.65% (p=0.000 n=10+8) StartTransactionSpan/cacheMiss-8 2.16kB ± 1% 2.39kB ± 0% +10.62% (p=0.000 n=10+10) name old allocs/op new allocs/op delta StartSpanFromParent-8 7.00 ± 0% 4.00 ± 0% -42.86% (p=0.000 n=10+10) StartTransactionSpan/cacheHit-8 10.3 ± 7% 6.0 ± 0% -41.75% (p=0.000 n=10+10) StartTransactionSpan/cacheMiss-8 35.3 ± 2% 18.0 ± 0% -49.01% (p=0.000 n=10+10) ``` An example of both extensive tracing and cadence tracing enabled: <img width="1459" alt="Screen Shot 2022-07-25 at 10 21 07 PM" src="https://user-images.githubusercontent.com/169976/180929610-edbfdc54-e604-401f-aea5-501af2f861b2.png"> - [x] test against localnet's Tempo instance. - [x] noop tracer. - [x] log tracer. - [x] merge cadence bits onflow/cadence#1824. - [x] merge onflow/flow-core-contracts#298. - [x] update cadence. Co-authored-by: Alexey Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference expression uses incorrect operator. Fix: switch
as?/as!toas.