Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linter #584

Merged
merged 6 commits into from
Jul 27, 2022
Merged

Update linter #584

merged 6 commits into from
Jul 27, 2022

Conversation

sideninja
Copy link
Contributor

@sideninja sideninja commented Jul 25, 2022 •
edited
Loading

Description

Update Github actions golangci-lint linter. Add go set up as part of the steps as that is no longer supported by golangci golangci/golangci-lint-action#442 (comment)

It also removes actions that were deprecated with Go1.18

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sideninja sideninja merged commit 0095fb2 into master Jul 27, 2022
@sideninja sideninja deleted the improvement/lint-gha branch November 24, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@psiemens psiemens Awaiting requested review from psiemens

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee Kay-Zee is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sideninja @janezpodhostnik