PKG -- [fcl-core] Add TransactionError type to better expose execution errors
#1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f2416c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jribbink
changed the title
TransactionError type to better expose execution errorsTransactionError type to better expose execution errors
Co-authored-by: Alex <[email protected]>
nialexsan
approved these changes
Jun 14, 2024
gregsantos
approved these changes
Oct 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1891
This helps expose errors in a more usable way for developers. They can now check the error code against a standardized set of enums to help them categorize errors better. This utility can also be used by wallet developers to surface failed transaction results to users.
I tried to make this implementation as change-proof as possible (doesn't edit the message/extract error message, code is optional, regex uses first occurance instead of start of string) because there are existing tickets in flow-go which aim to improve error reporting, so it's best to err on the side of caution and assume that this could change.
see:
onflow/flow-go#3781
onflow/cadence#2689