Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port internal #284 #3690

Merged
merged 16 commits into from
Nov 22, 2024
Merged

Port internal #284 #3690

merged 16 commits into from
Nov 22, 2024
+359 −58

Conversation

turbolent
Copy link
Member

Description

Port https://github.com/onflow/cadence-internal/pull/284

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

turbolent and others added 16 commits October 30, 2024 15:08
@turbolent
v1.0.2
aba82b4
@turbolent
Merge pull request #3655 from onflow/release/v1.0.2
0f12024
@turbolent
report error when inference of return type of invocation fails
90f36e9
@turbolent
report error when AST type cannot be converted
6de6720
@turbolent
add defensive check to reject expressions with invalid type, but no e…
f52f6a9 
…rror reported
@turbolent
report invalid type indexing error before returning invalid type
1ec7b3c
@turbolent
add test for remove with undeclared type
11fe59a
@SupunS @turbolent
Add test for invalid generic type
4be6dea
@turbolent
report error when parameter type in invocation cannot be inferred
a1f9e8b
@turbolent @SupunS
improve defensive check
39f6655 
Co-authored-by: Supun Setunga <[email protected]>
@turbolent
refactor defensive check into function
d1d5626
@turbolent
gate new behaviour (errors for all invalid type cases) behind a featu…
b4f27e1 
…re flag
@turbolent
Revert "gate new behaviour (errors for all invalid type cases) behind…
aecd31a 
… a feature flag"

This reverts commit 3e2ecc99b3a819ffb123723f62777a2655bbbae6.
@turbolent
Merge pull request #3684 from onflow/bastian/port-internal-284
36b5b2b 
[v1.0] Port internal #284
@turbolent
go mod tidy
127b0ee
@turbolent
Merge branch 'v1.0' into bastian/master-port-internal-284
e29fc35
@turbolent turbolent self-assigned this Nov 21, 2024
@github-actions GitHub Actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit b09231f
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent turbolent merged commit d555d17 into master Nov 22, 2024
8 of 12 checks passed
@turbolent turbolent deleted the bastian/master-port-internal-284 branch November 22, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@jsproz jsproz Awaiting requested review from jsproz

Assignees

@turbolent turbolent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turbolent @SupunS