Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for new storage format #745

Closed
4 tasks done
turbolent opened this issue Mar 30, 2021 · 0 comments
Closed
4 tasks done

Prepare for new storage format #745

turbolent opened this issue Mar 30, 2021 · 0 comments
Assignees
@fxamacker
Labels
Improvement

Comments

@turbolent
Copy link
Member

turbolent commented Mar 30, 2021 •
edited
Loading

Issue To Be Solved

Prepare the feature branch for storage optimizations, feature/storage-optimizations

Definition of Done

  • Bump CurrentEncodingVersion to 4

The decoder will from now on only support version 4.
However, we keep the existing decoder so we can still decoder the existing data when we are

  • Copy code in decode.go to decode_v3.go
  • Rename Decoder in decode_v3.go to DecoderV3. Keep it for the batch conversion / state migration
  • Rename current Decoder to DecoderV4, use it everywhere in the Cadence codebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxamacker fxamacker

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turbolent @fxamacker