Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INT-1311][python-onfleet] Delivery Manifest Endpoint #52

Merged
merged 2 commits into from
Jun 3, 2024
Merged

[INT-1311][python-onfleet] Delivery Manifest Endpoint #52

merged 2 commits into from
Jun 3, 2024

Conversation

lisandrobigi-onfleet
Copy link
Contributor

Describe the solution
New Onfleet Delivery Manifest API endpoint added as getDeliveryManifest method. In order to test the mentioned endpoints, the test file was updated using a dummy object.
https://docs.onfleet.com/reference/delivery-manifest

Added

  • Added getDeliveryManifest endpoint
  • Support to include Google Maps Directions API key, in this specific format Google <google_direction_api_key> in your HTTP header as X-API-KEY
  • Support for optional query parameters startDate and endDate.
  • Readme files were updated to support Workers POST method.

Changed

Deprecated

Removed

Fixed

Security

@lisandrobigi-onfleet lisandrobigi-onfleet self-assigned this May 27, 2024
danmenza
danmenza approved these changes May 28, 2024
View reviewed changes
Copy link

@danmenza danmenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved ✅

kaiserawu
kaiserawu requested changes May 29, 2024
View reviewed changes
Copy link
Contributor

@kaiserawu kaiserawu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one little note to double check. Everything else seems good.

onfleet/request.py Outdated Show resolved Hide resolved
@kaiserawu kaiserawu self-requested a review May 29, 2024 19:32
kaiserawu
kaiserawu approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@kaiserawu kaiserawu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lisandrobigi-onfleet lisandrobigi-onfleet merged commit 4ec42ef into master Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiserawu kaiserawu kaiserawu approved these changes

@danmenza danmenza danmenza approved these changes

Assignees

@lisandrobigi-onfleet lisandrobigi-onfleet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lisandrobigi-onfleet @kaiserawu @danmenza