Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publishing block in build.gradle #157

Closed
wants to merge 1 commit into from

Conversation

j-piasecki
Copy link

https://developer.android.com/build/releases/past-releases/agp-8-0-0-release-notes

AGP 8.0 creates no SoftwareComponent by default. Instead AGP creates SoftwareComponents only for variants that are configured to be published using the publishing DSL.

This causes the library not to build when used alongside React Native 0.73. Adding the publishing block, causes AGP to create the release component again, fixing the build.

See https://developer.android.com/build/publish-library/configure-pub-variants and https://developer.android.com/reference/tools/gradle-api/7.1/com/android/build/api/dsl/PublishingOptions

@onfido-sdk-ci
Copy link
Collaborator

onfido-sdk-ci commented Feb 15, 2024

Thank you for highlighting this. We do have a publishing block, however React Native 0.73 uses Gradle 8 which has introduced some API changes, such as this one. We have upgraded our Gradle and have fixed this issue. We are are including this in our upcoming release targeted for March 13.

@j-piasecki j-piasecki closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants