[Android] Fix Android build failures with RN 0.72

[fabioh8010]

Description

RN projects starting from 0.72 are going to use Gradle 8.x to build the Android app. This library is using a enabled flag in build.gradle that is already deprecated in Gradle 7.x and was removed in Gradle 8.x. This PR aims to solve this by using the new flag required.

Test Plan

1. Setup a RN project with the 0.72 release candidate.
2. Add @onfido/react-native-sdk library to project.
3. Run the Android build.
4. Verify if the build succeeds.
5. Repeat the steps above for a previous RN release, e.g 0.71, 0.70.

[fcaldarelli]

@fabioh8010 Are these changes compatible with RN < 0.72 ?

[sekoyo]

0.71 was on 7.6 and the property was deprecated since at least 6.1 which was released in Jan 15, 2020

https://docs.gradle.org/6.1/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:enabled

Although for some time it was replaced by "activated" before "required" in 7.1 (these guys really love breaking changes for subtle semantics...):

https://docs.gradle.org/7.1/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:enabled

v7.1 was released in Jun 14, 2021 so it should still be compat with pretty old versions of RN

[fabioh8010]

@fcaldarelli Just complementing @dominictobias info..

The "required" option was introduced in Gradle 6.8:

6.7.1 -> https://docs.gradle.org/6.7.1/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:enabled
6.8 -> https://docs.gradle.org/6.8/dsl/org.gradle.api.reporting.Report.html#org.gradle.api.reporting.Report:enabled
6.8 source code -> https://github.com/gradle/gradle/blob/v6.8.0/subprojects/reporting/src/main/java/org/gradle/api/reporting/Report.java

And RN started using Gradle 6.8+ in version 0.65 -> https://react-native-community.github.io/upgrade-helper/?from=0.64.4&to=0.65.0#RnDiffApp-android-gradle-wrapper-gradle-wrapper.properties

Since "this SDK supports React Native versions 0.68.2 and later", it should be completely safe to use "required" in the project.

[vlimag]

any updates on this?

[fior-seibold]

any update on the issue? This is currently a blocker.

[fcaldarelli]

Same for me. I can't update react-native to last 0.72.4 because this error.

[fabioh8010]

You can use patch-package as a temporary workaround while this PR is not merged yet, we are using in Expensify project -> https://github.com/Expensify/App/blob/main/patches/@onfido+react-native-sdk+7.4.0.patch

[fcaldarelli]

@fabioh8010 thank you, but temporary I solved with these 2 changes:

android/build.gradle

android/gradle/wrapper/gradle-wrapper.properties

Now OnFido package is building on RN 0.72.4

[fabioh8010]

I would recommend you to use patch-package for this case, it's safer than downgrading Gradle to 7.x (it can cause issues with other libraries or RN itself).

[fcaldarelli]

I would recommend you to use patch-package for this case, it's safer than downgrading Gradle to 7.x (it can cause issues with other libraries or RN itself).

I downgraded gradle and all libraries are working fine.

[omerkarakose]

We've also facing this issue and downgrading gradle wrapper version is not the ideal solution.

Can we please fix this and release a new version ?

[sekoyo]

Why is this still not merged. Are you stil actively maintaining Onfido support for RN? :/

[lbuljan]

Would somebody finally merge this?

[onfido-sdk-ci]

We have migrated to Gradle 8 and are including this change in our upcoming quarterly release targeted for March 13.

[onfido-sdk-ci]

This requested change however (using required instead of enabled) was already included in 10.5.0 released on November 29, 2023.