Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including faraday-follow_redirects as a runtime dependency in ruby #109

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

Kallin
Copy link
Contributor

@Kallin Kallin commented Aug 14, 2024

the current version of the onfido-ruby repository requires faraday-follow-redirects, but the gemspec generated by this project doesn't include it.

This causes our Rails project to fail when loading onfido configuration due to this line.

I expect this would be a problem for most anyone using the latest version of onfido-ruby.

@Kallin
Copy link
Contributor Author

Kallin commented Aug 15, 2024

perhaps you're not seeing this because whatever project you are including this in is already somehow dependent on faraday-follow-redirects directly or via some other gem? if it's not in the gem-spec, it won't get picked up by including projects as a transitive dependency.

btw, many projects just do something like this to include the gem-spec in the gemfile:

source "https://rubygems.org"

git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }

# Specify your gem's dependencies in gemspec
gemspec

might be a good option here to prevent this sort of mismatch from occuring

@Kallin
Copy link
Contributor Author

Kallin commented Aug 16, 2024

@DavidMealha-Onfido , any chance someone on your team could take a look at this? 🙏

@dvacca-onfido dvacca-onfido changed the title including faraday-follow_redirects as a ruby runtime dependency Including faraday-follow_redirects as a ruby runtime dependency in ruby Aug 19, 2024
Copy link
Contributor

@dvacca-onfido dvacca-onfido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @Kallin thanks for your contribution

@dvacca-onfido dvacca-onfido changed the title Including faraday-follow_redirects as a ruby runtime dependency in ruby Including faraday-follow_redirects as a runtime dependency in ruby Aug 19, 2024
@dvacca-onfido dvacca-onfido merged commit f5555a0 into onfido:master Aug 19, 2024
4 checks passed
@Kallin
Copy link
Contributor Author

Kallin commented Aug 19, 2024

@dvacca-onfido thx for accepting!

@Kallin
Copy link
Contributor Author

Kallin commented Aug 20, 2024

@dvacca-onfido, I'm curious how long you wait before running the Delivering client libraries (internal use only) process if you don't mind me asking.

@dvacca-onfido
Copy link
Contributor

@Kallin please bear with us, we'll go along that in the next few days.

@dvacca-onfido
Copy link
Contributor

@Kallin new library version has just been delivered:
https://github.com/onfido/onfido-ruby/releases/tag/v3.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants