-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including faraday-follow_redirects
as a runtime dependency in ruby
#109
Including faraday-follow_redirects
as a runtime dependency in ruby
#109
Conversation
…ects using the onfido-ruby gem
perhaps you're not seeing this because whatever project you are including this in is already somehow dependent on btw, many projects just do something like this to include the gem-spec in the gemfile:
might be a good option here to prevent this sort of mismatch from occuring |
@DavidMealha-Onfido , any chance someone on your team could take a look at this? 🙏 |
faraday-follow_redirects
as a ruby runtime dependencyfaraday-follow_redirects
as a ruby runtime dependency in ruby
Co-authored-by: dvacca-onfido <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @Kallin thanks for your contribution
faraday-follow_redirects
as a ruby runtime dependency in rubyfaraday-follow_redirects
as a runtime dependency in ruby
@dvacca-onfido thx for accepting! |
@dvacca-onfido, I'm curious how long you wait before running the |
@Kallin please bear with us, we'll go along that in the next few days. |
@Kallin new library version has just been delivered: |
the current version of the
onfido-ruby
repository requiresfaraday-follow-redirects
, but the gemspec generated by this project doesn't include it.This causes our Rails project to fail when loading onfido configuration due to this line.
I expect this would be a problem for most anyone using the latest version of
onfido-ruby
.