Refresh onfido-node after onfido-openapi-spec update (40b86a1) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiccardoPetteruti-Onfido
previously approved these changes
Jul 9, 2024
devops-automation-onfido
force-pushed
the
release-upgrade
branch
from
7d42882 to
6b6e962
Compare
devops-automation-onfido
changed the title
devops-automation-onfido
changed the title
devops-automation-onfido
force-pushed
the
release-upgrade
branch
from
6b6e962 to
0dbc83a
Compare
warrenseine
approved these changes
Jul 15, 2024
warrenseine
reviewed
Jul 15, 2024
| @@ -26,6 +26,7 @@ function getExpectedWorkflowRun( | |||
| return getExpectedObject(exampleWorkflowRun, { | |||
| applicant_id: expect.stringMatching(/^[0-9a-z-]+$/), | |||
| id: expect.stringMatching(/^[0-9a-z-]+$/), | |||
| customer_user_id: expect.stringMatching(/^[0-9a-z-]+$/), | |||
There was a problem hiding this comment.
Wait, actually, this can be any string. It's provided by the customer, so it's not necessarily a UUID.
There was a problem hiding this comment.
I'm going to fix that 👍
dvacca-onfido
force-pushed
the
release-upgrade
branch
from
4729e2d to
5d6dbaa
Compare
|
@franciscocastanho-onfido could you please check applicants.test.ts, it looks they started failing after your change? 🙏 |
franciscocastanho-onfido
force-pushed
the
release-upgrade
branch
from
e39e406 to
29c6eab
Compare
franciscocastanho-onfido
force-pushed
the
release-upgrade
branch
from
29c6eab to
a06d937
Compare
|
LGTM |
sofia-gomes-onfido
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-generated PR with changes till commit onfido/onfido-openapi-spec@40b86a1 (included)
Additional changes: