Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAT-1120] Improve npm release #116

Merged
merged 10 commits into from
May 6, 2024
Merged

[CAT-1120] Improve npm release #116

merged 10 commits into from
May 6, 2024

Conversation

dvacca-onfido
Copy link
Contributor

@dvacca-onfido dvacca-onfido commented May 3, 2024

A few additional changes to improve delivering of the package to npm. Includes the removal of unneeded openapi generator files and removal of forgotten .only in workflow-flow-runs tests.

@dvacca-onfido dvacca-onfido self-assigned this May 3, 2024
Comment on lines +31 to +33
"files": [
"/dist"
],
Copy link
Contributor Author

@dvacca-onfido dvacca-onfido May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to obtain same package structure in npm archive as old npm package (v2.9.0).

Example of a npm package session (with --dry-run option):

npm notice 
npm notice 📦  @onfido/[email protected]
npm notice === Tarball Contents === 
npm notice 1.1kB   LICENSE                             
npm notice 5.4kB   README.md                           
npm notice 373.[8](https://github.com/onfido/onfido-node/actions/runs/8969224299/job/24630303554#step:5:9)kB dist/api.d.ts                       
npm notice 2[9](https://github.com/onfido/onfido-node/actions/runs/8969224299/job/24630303554#step:5:10)2.1kB dist/api.js                         
npm notice 1.4kB   dist/base.d.ts                      
npm notice 1.5kB   dist/base.js                        
npm notice 1.8kB   dist/common.d.ts                    
npm notice 7.2kB   dist/common.js                      
npm notice 2.5kB   dist/configuration.d.ts             
npm notice 2.2kB   dist/configuration.js               
npm notice 373.8kB dist/esm/api.d.ts                   
npm notice 283.0kB dist/esm/api.js                     
npm notice 1.4kB   dist/esm/base.d.ts                  
npm notice 1.2kB   dist/esm/base.js                    
npm notice 1.8kB   dist/esm/common.d.ts                
npm notice 6.4kB   dist/esm/common.js                  
npm notice 2.5kB   dist/esm/configuration.d.ts         
npm notice 2.0kB   dist/esm/configuration.js           
npm notice 366B    dist/esm/index.d.ts                 
npm notice 408B    dist/esm/index.js                   
npm notice 340B    dist/esm/webhook-event-verifier.d.ts
npm notice 1.2kB   dist/esm/webhook-event-verifier.js  
npm notice 366B    dist/index.d.ts                     
npm notice 1.2kB   dist/index.js                       
npm notice 340B    dist/webhook-event-verifier.d.ts    
npm notice 1.4kB   dist/webhook-event-verifier.js      
npm notice 1.4kB   package.json                        
npm notice === Tarball Details === 
npm notice name:          @onfido/api                             
npm notice version:       3.0.0                                   
npm notice filename:      @onfido/api-3.0.0.tgz                   
npm notice package size:  [12](https://github.com/onfido/onfido-node/actions/runs/8969224299/job/24630303554#step:5:13)2.5 kB                                
npm notice unpacked size: 1.4 MB                                  
npm notice shasum:        01d87704ed4dbf4387d6ac83776bf49eb5f74907
npm notice integrity:     sha512-03gzgmw0lJ9MX[...]krm/h7EIAueSQ==
npm notice total files:   27                                      
npm notice 
npm WARN This command requires you to be logged in to github:onfido/onfido-node (dry-run)
npm notice Publishing to github:onfido/onfido-node (dry-run)
+ @onfido/[email protected]

Change will be persisted in template via onfido/onfido-openapi-spec@3864e6d.

@dvacca-onfido dvacca-onfido changed the title [CAT-1120] Improve delivery [CAT-1120] Improve npm release May 6, 2024
@dvacca-onfido dvacca-onfido marked this pull request as ready for review May 6, 2024 13:18
@dvacca-onfido dvacca-onfido merged commit cd2a081 into master May 6, 2024
6 checks passed
@dvacca-onfido dvacca-onfido deleted the improve-delivery branch May 6, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants