-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAT-1120] Improve npm release #116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvacca-onfido
force-pushed
the
improve-delivery
branch
from
May 3, 2024 07:33
2a3018c
to
20959f7
Compare
dvacca-onfido
force-pushed
the
improve-delivery
branch
from
May 3, 2024 07:33
20959f7
to
e49d938
Compare
dvacca-onfido
commented
May 6, 2024
Comment on lines
+31
to
+33
"files": [ | ||
"/dist" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to obtain same package structure in npm archive as old npm package (v2.9.0).
Example of a npm package session (with --dry-run
option):
npm notice
npm notice 📦 @onfido/[email protected]
npm notice === Tarball Contents ===
npm notice 1.1kB LICENSE
npm notice 5.4kB README.md
npm notice 373.[8](https://github.com/onfido/onfido-node/actions/runs/8969224299/job/24630303554#step:5:9)kB dist/api.d.ts
npm notice 2[9](https://github.com/onfido/onfido-node/actions/runs/8969224299/job/24630303554#step:5:10)2.1kB dist/api.js
npm notice 1.4kB dist/base.d.ts
npm notice 1.5kB dist/base.js
npm notice 1.8kB dist/common.d.ts
npm notice 7.2kB dist/common.js
npm notice 2.5kB dist/configuration.d.ts
npm notice 2.2kB dist/configuration.js
npm notice 373.8kB dist/esm/api.d.ts
npm notice 283.0kB dist/esm/api.js
npm notice 1.4kB dist/esm/base.d.ts
npm notice 1.2kB dist/esm/base.js
npm notice 1.8kB dist/esm/common.d.ts
npm notice 6.4kB dist/esm/common.js
npm notice 2.5kB dist/esm/configuration.d.ts
npm notice 2.0kB dist/esm/configuration.js
npm notice 366B dist/esm/index.d.ts
npm notice 408B dist/esm/index.js
npm notice 340B dist/esm/webhook-event-verifier.d.ts
npm notice 1.2kB dist/esm/webhook-event-verifier.js
npm notice 366B dist/index.d.ts
npm notice 1.2kB dist/index.js
npm notice 340B dist/webhook-event-verifier.d.ts
npm notice 1.4kB dist/webhook-event-verifier.js
npm notice 1.4kB package.json
npm notice === Tarball Details ===
npm notice name: @onfido/api
npm notice version: 3.0.0
npm notice filename: @onfido/api-3.0.0.tgz
npm notice package size: [12](https://github.com/onfido/onfido-node/actions/runs/8969224299/job/24630303554#step:5:13)2.5 kB
npm notice unpacked size: 1.4 MB
npm notice shasum: 01d87704ed4dbf4387d6ac83776bf49eb5f74907
npm notice integrity: sha512-03gzgmw0lJ9MX[...]krm/h7EIAueSQ==
npm notice total files: 27
npm notice
npm WARN This command requires you to be logged in to github:onfido/onfido-node (dry-run)
npm notice Publishing to github:onfido/onfido-node (dry-run)
+ @onfido/[email protected]
Change will be persisted in template via onfido/onfido-openapi-spec@3864e6d.
dvacca-onfido
changed the title
[CAT-1120] Improve delivery
[CAT-1120] Improve npm release
May 6, 2024
dvacca-onfido
requested review from
DavidMealha-Onfido,
RiccardoPetteruti-Onfido and
sofia-gomes-onfido
May 6, 2024 13:11
DavidMealha-Onfido
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few additional changes to improve delivering of the package to npm. Includes the removal of unneeded openapi generator files and removal of forgotten
.only
in workflow-flow-runs tests.