Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update onfido-node after onfido-openapi-spec update #110

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

devops-automation-onfido
Copy link
Collaborator

  • Auto-generated PR

Copy link
Contributor

@dvacca-onfido dvacca-onfido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests

...{ headers: {...param.baseOptions?.headers,
...{'User-Agent': 'onfido-node/3.0.0'}}}};
...{'User-Agent': 'onfido-node/2.9.1'}}}};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But isn't this wrong? Shouldn't it be 3.1.0?

Copy link
Contributor

@dvacca-onfido dvacca-onfido Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump was not expected here, due to a bug which should be fixed with onfido/onfido-openapi-spec#56. There will be a major version update before actual delivery.

Last tag is 2.9.0, that why we've got 2.9.1. Therefore with major update (which will override this change) we should get to version 3.0.0. We can safely ignore these changes for now.

@@ -1,6 +1,6 @@
{
"name": "@onfido/api",
"version": "3.0.0",
"version": "2.9.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above, this should be 3.1.0

@dvacca-onfido dvacca-onfido changed the title Release onfido-node 2.9.1 after onfido-openapi-spec update Update onfido-node after onfido-openapi-spec update Mar 27, 2024
@dvacca-onfido dvacca-onfido merged commit dd96a8b into master Mar 27, 2024
6 checks passed
@dvacca-onfido dvacca-onfido deleted the release-upgrade branch March 27, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants