test: add tests focusing on workflow run outputs, document and facial similarity reports #109
Conversation
sofia-gomes-onfido
force-pushed
the
test/add-more-tests
branch
from
4da382d to
2963f9b
Compare
| workflow_version_id: expect.anything(), | ||
| dashboard_url: expect.anything(), | ||
| status: expect.anything(), | ||
| output: expect.anything(), |
There was a problem hiding this comment.
I think it would be worth it validating output field to be sure it's accessible even if not defined in detail.
There was a problem hiding this comment.
I ran these tests locally, and they're returning null in the output. Is that expected?
There was a problem hiding this comment.
We haven't validated enough this output field yet, but the goal of improving these tests over was also to be sure that what is returned in output field, even if can't be mapped to a precise schema, it can be accessible.
Therefore probably workflow run should be improved to have some data in this field so that we can see such data can be accessed using client library.
There was a problem hiding this comment.
In Studio clients can define output to be whatever they want (a string, an object, etc). In my latest changes, I've added validations for output containing:
- the outcome of a profile data capture task
- the result of a document report and a facial similarity report
sergiomartins8
force-pushed
the
test/add-more-tests
branch
2 times, most recently
from
b71f344 to
c9e777a
Compare
sofia-gomes-onfido
force-pushed
the
test/add-more-tests
branch
4 times, most recently
from
14f7dcd to
fe1ddac
Compare
sofia-gomes-onfido
force-pushed
the
test/add-more-tests
branch
from
fe1ddac to
8dcc748
Compare
| @@ -43,10 +43,11 @@ | |||
| "devDependencies": { | |||
| "@faker-js/faker": "^8.4.1", | |||
| "@types/jest": "^26.0.15", | |||
| "@types/node": "^12.11.5", | |||
| "dotenv": "^16.4.5", | |||
There was a problem hiding this comment.
Fine adding that this way for now. I've created PR#69 to not forget about this change.
sofia-gomes-onfido
changed the title
Add tests for workflow run outputs.
The
outputfield of workflow runs is configured within Studio workflow builder and can yield anything the client configures.The tests added validate there are no schema errors when the output is configured to be the result of a Profile Data Capture task, of a Document Report and of a Facial Similarity Photo Report.
I've also added tests validating the outcome of Document and Facial Similarity reports.