chore: followup bug 1927094 - optimize lineScrollAmount so it doesn't…

… iterate over all tabs
onemen · Nov 15, 2024 · 33a206b · 33a206b
1 parent 4f350c9
commit 33a206b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/addon/chrome/content/tab/scrollbox.js b/addon/chrome/content/tab/scrollbox.js
@@ -176,13 +176,6 @@ Tabmix.multiRow = {
           '$& && !this.isMultiRow', {flags: "g"}
         ).toCode();
 
-        Tabmix.changeCode(this, "scrollbox.lineScrollAmount", {getter: true})._replace(
-          '{', `{
-                  if (this.isMultiRow) {
-                    return this.scrollSize / Tabmix.tabsUtils.lastTabRowNumber;
-                  }`
-        ).defineProperty();
-
         const codeToReplace = Tabmix.isVersion(1310) ? 'this.#verticalMode' : 'this.getAttribute("orient") == "vertical"';
         Tabmix.changeCode(this, "scrollbox.on_touchstart")._replace(
           codeToReplace, 'this._verticalMode', {silent: true}

diff --git a/addon/chrome/content/tabmix.js b/addon/chrome/content/tabmix.js
@@ -1030,7 +1030,7 @@ var TMP_eventListener = {
         let scrollAmount = 0;
         if (TabmixTabbar.isMultiRow) {
           delta = delta > 0 ? 1 : -1;
-          scrollAmount = delta * tabStrip.lineScrollAmount;
+          scrollAmount = delta * (tabStrip.scrollSize / Tabmix.tabsUtils.lastTabRowNumber);
         } else if (aEvent.deltaMode == aEvent.DOM_DELTA_PIXEL) {
           scrollAmount = delta;
           instant = true;

diff --git a/types/addon.d.ts b/types/addon.d.ts
@@ -276,6 +276,7 @@ declare namespace TabmixArrowScrollboxNS {
     minOffset: number;
     offsetRatio: number;
     parentNode: MockedGeckoTypes.TabContainer;
+    readonly scrollSize: number;
     readonly shadowRoot: ShadowRoot;
     scrollboxPaddingBottom: number;
     scrollboxPaddingTop: number;