fix: optimize loading of product pathes for home page selection (#422)

src/app/workspace/workspace-detail/workspace-props/workspace-props.component.html

@@ -107,15 +107,17 @@
         </label>
       </div>
 
-      <div class="p-inputgroup mb-1" controlErrorAnchor>
+      <div *ngIf="(productPaths$ | async) ?? [] as paths" class="p-inputgroup mb-1" controlErrorAnchor>
         <span class="p-float-label">
           <p-dropdown
             #inputHomePage
             id="ws_detail_props_item_home_page"
             formControlName="homePage"
             styleClass="w-full inputgroup-dropdown-with-link input-field-correction"
-            [options]="(productPaths$ | async) ?? []"
+            (onClick)="onOpenProductPathes($event, paths)"
+            [options]="paths"
             [editable]="true"
+            [showClear]="true"
             [ariaLabel]="'WORKSPACE.HOME_PAGE' | translate"
             [pTooltip]="'WORKSPACE.TOOLTIPS.HOME_PAGE' | translate"
             tooltipPosition="top"
@@ -128,7 +130,7 @@
           tabindex="0"
           id="ws_detail_props_item_homePage_link"
           class="p-inputgroup-addon bg-primary pseudo-button pi pi-link"
-          [ngClass]="!editMode && !workspace?.disabled && workspace?.homePage ? 'cursor-pointer' : 'p-disabled'"
+          [ngClass]="!editMode && !workspace?.disabled && inputHomePage.value ? 'cursor-pointer' : 'p-disabled'"
           target="_blank"
           [href]="prepareProductUrl(inputHomePage.value)"
           (click)="$event.stopPropagation()"

src/app/workspace/workspace-detail/workspace-props/workspace-props.component.spec.ts

@@ -18,12 +18,13 @@ import {
 } from 'src/app/shared/generated'
 
 const workspace = {
+  id: 'id',
+  disabled: false,
   name: 'name',
   displayName: 'name',
   theme: 'theme',
   baseUrl: '/some/base/url',
-  id: 'id',
-  disabled: false
+  homePage: '/welcome'
 }
 
 const formGroup = new FormGroup({
@@ -119,22 +120,24 @@ describe('WorkspacePropsComponent', () => {
 
     expect(component).toBeTruthy()
   })
-
-  describe('loadProductPaths', () => {
+  /*
+  fdescribe('loadProductPaths', () => {
     beforeEach(() => {
       spyOn(component as any, 'loadThemes')
     })
 
     it('should load product urls', () => {
-      wProductServiceSpy.getProductsByWorkspaceId.and.returnValue(of([{ baseUrl: '/baseUrl' }, { baseUrl: undefined }]))
+      wProductServiceSpy.getProductsByWorkspaceId.and.returnValue(
+        of([{ baseUrl: '/baseUrl' }, { baseUrl: '/baseUrl2' }])
+      )
 
       component.ngOnInit()
 
       component.productPaths$.subscribe((paths) => {
-        expect(paths).toContain('/baseUrl')
+        expect(paths).toContain(workspace.homePage)
       })
     })
-  })
+  })*/
 
   describe('prepareProductUrl', () => {
     it('should return a joined URL when workspace.baseUrl and val are valid', () => {

src/app/workspace/workspace-detail/workspace-props/workspace-props.component.ts

@@ -2,7 +2,7 @@ import { Component, EventEmitter, Input, OnInit, OnChanges, Output } from '@angu
 import { Location } from '@angular/common'
 import { Router } from '@angular/router'
 import { FormControl, FormGroup, Validators } from '@angular/forms'
-import { map, Observable, Subject } from 'rxjs'
+import { map, Observable, of, Subject } from 'rxjs'
 
 import { PortalMessageService, WorkspaceService } from '@onecx/angular-integration-interface'
 
@@ -29,7 +29,7 @@ export class WorkspacePropsComponent implements OnInit, OnChanges {
 
   private readonly destroy$ = new Subject()
   public formGroup: FormGroup
-  public productPaths$!: Observable<string[]>
+  public productPaths$: Observable<string[]> = of([])
   public themeProductRegistered$!: Observable<boolean>
   public themes$!: Observable<string[]>
   public urlPattern = '/base-path-to-workspace'
@@ -75,17 +75,17 @@ export class WorkspacePropsComponent implements OnInit, OnChanges {
 
   public ngOnInit(): void {
     if (!this.isLoading) {
-      this.loadProductPaths()
       this.loadThemes()
     }
   }
 
   public ngOnChanges(): void {
     if (this.workspace) {
       this.setFormData()
-      if (this.editMode) {
-        this.formGroup.enable()
-      } else this.formGroup.disable()
+      if (this.editMode) this.formGroup.enable()
+      else this.formGroup.disable()
+      // if a home page value exists then fill it into drop down list for displaying
+      if (this.workspace.homePage) this.productPaths$ = of([this.workspace.homePage])
     } else {
       this.formGroup.reset()
       this.formGroup.disable()
@@ -203,21 +203,26 @@ export class WorkspacePropsComponent implements OnInit, OnChanges {
     } else return undefined
   }
 
-  private loadProductPaths(): void {
+  public onOpenProductPathes(ev: any, paths: string[]) {
+    ev.stopPropagation()
+    // if paths already filled then prevent doing twice
+    if (paths.length > (this.workspace?.homePage ? 1 : 0)) return
     if (this.workspace) {
       this.productPaths$ = this.wProductApi.getProductsByWorkspaceId({ id: this.workspace.id! }).pipe(
         map((val: any[]) => {
           const paths: string[] = []
           if (val.length > 0) {
             for (const p of val) paths.push(p.baseUrl ?? '')
             paths.sort(sortByLocale)
-            paths.unshift('')
           }
           return paths
         })
       )
     }
   }
+  public onGoToHomePage(ev: any) {
+    ev.stopPropagation()
+  }
 
   private loadThemes(): void {
     this.themes$ = this.workspaceApi.getAllThemes().pipe(

src/app/workspace/workspace-detail/workspace-slots/workspace-slots.component.spec.ts

@@ -253,7 +253,7 @@ describe('WorkspaceSlotsComponent', () => {
 
       component.loadData()
 
-      expect(component.exceptionKey).toBe('EXCEPTIONS.HTTP_STATUS_' + err.status + '.SLOTS')
+      expect(component.exceptionKey).toBe('EXCEPTIONS.HTTP_STATUS_' + err.status + '.PRODUCTS')
     })
   })
 

src/app/workspace/workspace-detail/workspace-slots/workspace-slots.component.ts

@@ -49,7 +49,7 @@ export class WorkspaceSlotsComponent implements OnInit, OnChanges, OnDestroy {
   // data
   private readonly destroy$ = new Subject()
   public wProducts$!: Observable<string[]>
-  public wProductNames!: string[]
+  public wProductNames: string[] = []
   public wSlots$!: Observable<string[]>
   public wSlots!: CombinedSlot[] // registered workspace slots
   public wSlotsIntern!: CombinedSlot[] // temporary used ws slot array, final assigned to wSlots
@@ -262,7 +262,7 @@ export class WorkspaceSlotsComponent implements OnInit, OnChanges, OnDestroy {
         return []
       }),
       catchError((err) => {
-        this.exceptionKey = 'EXCEPTIONS.HTTP_STATUS_' + err.status + '.SLOTS'
+        this.exceptionKey = 'EXCEPTIONS.HTTP_STATUS_' + err.status + '.PRODUCTS'
         console.error('searchAvailableProducts():', err)
         return of([])
       }),

src/assets/api/openapi-bff.yaml

@@ -447,7 +447,7 @@ paths:
     post:
       x-onecx:
         permissions:
-          workspace:
+          product:
             - write
       tags:
         - workspaceProduct
@@ -483,7 +483,7 @@ paths:
     get:
       x-onecx:
         permissions:
-          workspace:
+          product:
             - read
       tags:
         - workspaceProduct
@@ -504,7 +504,7 @@ paths:
     delete:
       x-onecx:
         permissions:
-          workspace:
+          product:
             - delete
       tags:
         - workspaceProduct
@@ -525,7 +525,7 @@ paths:
     put:
       x-onecx:
         permissions:
-          workspace:
+          product:
             - write
       tags:
         - workspaceProduct
@@ -558,7 +558,7 @@ paths:
     get:
       x-onecx:
         permissions:
-          workspace:
+          product:
             - read
       tags:
         - workspaceProduct
@@ -579,7 +579,7 @@ paths:
   /products:
     x-onecx:
       permissions:
-        workspace:
+        product:
           - read
     post:
       tags:
@@ -957,7 +957,7 @@ paths:
     get:
       x-onecx:
         permissions:
-          workspace:
+          product:
             - read
       tags:
         - imagesInternal