feat: handle null value and adjusted test (#27)

onecx · May 17, 2024 · 99cdb70 · 99cdb70
1 parent 5f88b67
commit 99cdb70
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/main/java/org/tkit/onecx/shell/bff/rs/mappers/WorkspaceConfigMapper.java b/src/main/java/org/tkit/onecx/shell/bff/rs/mappers/WorkspaceConfigMapper.java
@@ -4,6 +4,7 @@
 
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.stream.Collectors;
 
 import org.mapstruct.AfterMapping;
@@ -110,6 +111,7 @@ default SlotDTO createSlot(WorkspaceWrapperSlot slot) {
 
         SlotDTO result = new SlotDTO().name(slot.getName());
         if (slot.getComponents() != null) {
+            slot.getComponents().removeIf(Objects::isNull);
             slot.getComponents()
                     .forEach(c -> result.addComponentsItem(componentName(c.getProductName(), c.getAppId(), c.getName())));
         }

diff --git a/src/test/java/org/tkit/onecx/shell/bff/rs/WorkspaceConfigRestControllerTest.java b/src/test/java/org/tkit/onecx/shell/bff/rs/WorkspaceConfigRestControllerTest.java
@@ -234,6 +234,7 @@ void loadWorkspaceConfigByBaseUrlTest() {
                                 .addMicrofrontendsItem(new Microfrontend().basePath("/app1").mfeId("app1")))
                 .addSlotsItem(
                         new WorkspaceWrapperSlot().name("slot1")
+                                .addComponentsItem(null)
                                 .addComponentsItem(
                                         new WorkspaceWrapperComponent().productName("product1").appId("app1")
                                                 .name("App1Component"))