Change technology field to dropdown, increase test coverage img conta…

…iner (#97) * feat: change technology field to dropdown * feat: increase test coverage in image container --------- Co-authored-by: Christian Badura <[email protected]>
onecx · Apr 8, 2024 · 263868d · 263868d
1 parent b3e9d0e
commit 263868d
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 7 deletions.
diff --git a/src/app/product-store/app-detail/app-detail.component.html b/src/app/product-store/app-detail/app-detail.component.html
@@ -51,16 +51,16 @@
         </div>
         <div class="col-12 md:col-6" style="min-width: 15rem" [title]="'APP.TOOLTIPS.TECHNOLOGY' | translate">
           <span class="p-float-label" controlErrorAnchor>
-            <input
-              pInputText
-              type="text"
+            <p-dropdown
               id="app_detail_form_mfe_technology"
-              class="w-full pt-3 pb-2"
-              formControlName="exposedModule"
+              styleClass="w-full min-w-min input-field-correction"
+              formControlName="technology"
               [pTooltip]="'APP.TOOLTIPS.TECHNOLOGY' | translate"
               tooltipPosition="top"
               tooltipEvent="focus"
-            />
+              [options]="technologies"
+            >
+            </p-dropdown>
             <label class="ocx-required-label" for="app_detail_form_mfe_technology">
               {{ 'APP.TECHNOLOGY' | translate }}
             </label>

diff --git a/src/app/product-store/app-detail/app-detail.component.ts b/src/app/product-store/app-detail/app-detail.component.ts
@@ -64,6 +64,10 @@ export class AppDetailComponent implements OnChanges {
   public loading = false
   public hasCreatePermission = false
   public hasEditPermission = false
+  public technologies: SelectItem[] = [
+    { label: 'Angular', value: 'ANGULAR' },
+    { label: 'WebComponent', value: 'WEBCOMPONENT' }
+  ]
   public iconItems: SelectItem[] = [{ label: '', value: null }] // default value is empty
   public convertToUniqueStringArray = convertToUniqueStringArray
 

diff --git a/src/app/shared/image-container/image-container.component.spec.ts b/src/app/shared/image-container/image-container.component.spec.ts
@@ -2,13 +2,26 @@ import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing'
 import { ImageContainerComponent } from './image-container.component'
 import { prepareUrl } from 'src/app/shared/utils'
 
+import { AppStateService } from '@onecx/portal-integration-angular'
+import { of } from 'rxjs'
+
+class MockAppStateService {
+  currentMfe$ = of({
+    remoteBaseUrl: '/base/'
+  })
+}
+
 describe('ImageContainerComponent', () => {
   let component: ImageContainerComponent
   let fixture: ComponentFixture<ImageContainerComponent>
+  let mockAppStateService: MockAppStateService
 
   beforeEach(waitForAsync(() => {
+    mockAppStateService = new MockAppStateService()
+
     TestBed.configureTestingModule({
-      declarations: [ImageContainerComponent]
+      declarations: [ImageContainerComponent],
+      providers: [{ provide: AppStateService, useValue: mockAppStateService }]
     }).compileComponents()
   }))
 
@@ -20,6 +33,7 @@ describe('ImageContainerComponent', () => {
 
   it('should create', () => {
     expect(component).toBeTruthy()
+    expect(component.defaultImageUrl).toEqual('/base/./assets/images/product.jpg')
   })
 
   describe('ngOnChanges', () => {