Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: standalone mode #614

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

bastianjakobi
Copy link
Contributor

No description provided.

@bastianjakobi bastianjakobi self-assigned this Nov 19, 2024
@bastianjakobi bastianjakobi marked this pull request as ready for review December 9, 2024 23:09
@bastianjakobi
Copy link
Contributor Author

create-translate-loader-update.md

Guide for migrating to new translate loader.

Copy link
Contributor

@markuczy markuczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work :>

Comment on lines +58 to +82
function hasPermissionCheckerFactory(parentInjector: Injector, hasPermissionChecker: HasPermissionChecker) {
if (!hasPermissionChecker) {
const hasUserService = !!parentInjector.get(UserService, null)
const injectorConfig: {
providers: Array<Provider | StaticProvider>
parent?: Injector
name?: string
} = {
providers: [
{
provide: HAS_PERMISSION_CHECKER,
useExisting: UserService,
},
],
parent: parentInjector,
}
if (!hasUserService) {
injectorConfig.providers.push(UserService)
}
const injector = Injector.create(injectorConfig)
hasPermissionChecker = injector.get(HAS_PERMISSION_CHECKER)
}
return hasPermissionChecker
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test this?

@@ -0,0 +1,7 @@
// TODO copy + refactor tests from angular-accelerator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants