feat: move components to angular-accelerator #526
Conversation
…into feature/P002271-7179-move-components-to-accelerator
| @@ -0,0 +1,3 @@ | |||
| <div [ocxContent]="title" [style]="styleClass"> | |||
There was a problem hiding this comment.
The styleClass input should be applied as a class, not as a custom style. The same also applies to the content container component. Please also make sure that the style classes provided via input have a higher priority than the classes which are added by the directive itself. This way we don't only allow devs to specify additional classes but also allow them to overwrite existing style classes such as padding through the given input.
There was a problem hiding this comment.
Please verify the class merging behavior described above in a unit test.
There was a problem hiding this comment.
After clarifying with @SchettlerKoehler we decided to delete all files from PIA after migrating them to angular-accelerator. Importing the migrated components from PIA should still work because PIA re-exports everything from angular-accelerator (see attached file).
Please delete all components and files that have been migrated as part of this PR.
There was a problem hiding this comment.
Please remove this file as it didn't exist previously and shouldn't be necessary in our repo.
|
Please also update your fork's main branch and merge it into your working branch |
| {{ item?.columnName ? (item.columnName | translate) : ''}} | ||
| </ng-template></p-dropdown | ||
| > | ||
| <label for="dataListGridSortingDropdown">{{ ("OCX_LIST_GRID_SORT.DROPDOWN.ARIA_LABEL" | translate) }}</label> |
There was a problem hiding this comment.
Could you please create a separate translation OCX_LIST_GRID_SORT.DROPDOWN.LABEL for the floating label? This way, we can change the aria label in the future without unexpectedly modifying the displayed floating label. The new translation key can have the exact same value as the previously used aria label translation.
…ttps://github.com/mollend0/onecx-portal-ui-libs into feature/P002271-7179-move-components-to-accelerator
…ttps://github.com/mollend0/onecx-portal-ui-libs into feature/P002271-7179-move-components-to-accelerator
No description provided.