Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add length getter to DynamicLocaleId #393

Merged
merged 2 commits into from
Aug 13, 2024
Merged

fix: add length getter to DynamicLocaleId #393

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
362a974
fix: add length getter to DynamicLocaleId
bastianjakobi Aug 13, 2024
6d71a92
fix: fix test
bastianjakobi Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion libs/angular-accelerator/src/lib/utils/dynamic-locale-id.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { UserService } from '@onecx/angular-integration-interface'
export class DynamicLocaleId {
constructor(private userService: UserService) {
Object.getOwnPropertyNames(String.prototype).forEach((k) => {
if (k != 'valueOf') {
if (k != 'valueOf' && k != 'length') {
;(this as any)[k] = function (...args: any[]) {
const str = this.valueOf()
return str[k](...args)
Expand All @@ -15,4 +15,10 @@ export class DynamicLocaleId {
valueOf() {
return this.userService.lang$.getValue()
}


public get length() : number {
return this.valueOf().length
}

}
Loading