fix: fixed accessibilty issues for pageHeaderComponent #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jufiedle
commented
Jul 23, 2024
jufiedle
commented
- fixed one button (added ariaLabel)
- replaced html tooltips with primeNG tooltips
anninowak
changed the title
SchettlerKoehler
requested changes
Jul 29, 2024
SchettlerKoehler
approved these changes
Jul 31, 2024
SchettlerKoehler
approved these changes
Aug 1, 2024
jufiedle
added a commit
to jufiedle/onecx-portal-ui-libs
that referenced
this pull request
Aug 1, 2024
* P002271-7641: fixing accessibility issues for pageHeaderComponent * P002271-7641: fix failing test * P002271-7641: fix test * P002271-7641: renamed function for better understanding * P002271-7641: function refactoring
KimFFVII
pushed a commit
that referenced
this pull request
Aug 2, 2024
* fix: fixed accessibilty issues for pageHeaderComponent (#330) * P002271-7641: fixing accessibility issues for pageHeaderComponent * P002271-7641: fix failing test * P002271-7641: fix test * P002271-7641: renamed function for better understanding * P002271-7641: function refactoring * fix: added missing changes for aria-label --------- Co-authored-by: kim.tran <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
## [4.46.0](v4.45.0...v4.46.0) (2024-08-06) ### Features * permission checker optional ([#370](#370)) ([2e2a0c2](2e2a0c2)), closes [#346](#346) ### Bug Fixes * fixed accessibilty issues for pageHeaderComponent ([#330](#330)) ([#357](#357)) ([63ed32e](63ed32e)) * P002271 7753/refactoring get url ([#354](#354)) ([2d54477](2d54477))
github-actions bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
## [5.3.1](v5.3.0...v5.3.1) (2024-08-06) ### Bug Fixes * fixed accessibilty issues for pageHeaderComponent ([#330](#330)) ([f162a23](f162a23)) ### Chores * [nx migration] changes ([#358](#358)) ([7cd1bf5](7cd1bf5)) * **deps-dev:** bump @schematics/angular from 18.0.7 to 18.1.3 ([#360](#360)) ([96efab1](96efab1)) * **deps-dev:** bump @storybook/core-server from 8.2.6 to 8.2.7 ([#362](#362)) ([fc5d713](fc5d713)) * **deps-dev:** bump @types/node from 20.14.12 to 22.1.0 ([#365](#365)) ([ab3a795](ab3a795)) * **deps-dev:** bump @typescript-eslint/parser from 7.17.0 to 7.18.0 ([#368](#368)) ([a522d28](a522d28)) * **deps-dev:** bump msw from 2.3.4 to 2.3.5 ([#367](#367)) ([ea8d5b4](ea8d5b4)) * **deps:** bump the angular group with 20 updates ([#359](#359)) ([78a97e5](78a97e5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.