Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix styling issues for page header detail values + add ability to specify icon styles #294

Merged
merged 3 commits into from
Jun 27, 2024
Merged

feat: fix styling issues for page header detail values + add ability to specify icon styles #294

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79c1796
fix: fix layout + styling issues for page header detail values
Jun 26, 2024
d250b31
fix: fix broken tests
Jun 26, 2024
fb09fc6
feat: add ability to add styleclasses to objectDetail icons
Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions libs/angular-accelerator/src/lib/components/page-header/page-header.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,20 +105,24 @@ <h2 id="page-subheader" *ngIf="!!subheader">{{ subheader }}</h2>
>
<span
*ngIf="item.icon || item.value"
class="flex text-900 align-items-center gap-2 object-info-grid-value"
[ngClass]="generateItemStyle(item)"
class="object-info-grid-value"
[title]="item.valueTooltip || item.tooltip || ''"
name="object-detail-value"
>
<i *ngIf="item.icon" class="{{item.icon}}" name="object-detail-icon"></i>
{{ item.value | dynamicPipe:item.valuePipe:item.valuePipeArgs}}
<p-button
*ngIf="item.actionItemIcon && item.actionItemCallback"
[icon]="item.actionItemIcon"
styleClass="p-button-text p-0 w-full"
[title]="item.actionItemTooltip || ''"
(onClick)="item.actionItemCallback()"
></p-button>
<span
class="flex text-900 align-items-center gap-2 w-max"
[ngClass]="generateItemStyle(item)"
name="object-detail-value"
>
<i *ngIf="item.icon" class="{{item.icon}}" name="object-detail-icon"></i>
{{ item.value | dynamicPipe:item.valuePipe:item.valuePipeArgs}}
<p-button
*ngIf="item.actionItemIcon && item.actionItemCallback"
[icon]="item.actionItemIcon"
styleClass="p-button-text p-0 w-full"
[title]="item.actionItemTooltip || ''"
(onClick)="item.actionItemCallback()"
></p-button>
</span>
</span>
</div>
</ng-container>
Expand Down
Loading