Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused getters and broken conditional (#79) #113

Merged
merged 1 commit into from
Feb 6, 2024
Merged

refactor: remove unused getters and broken conditional (#79) #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/portal-integration-angular/src/lib/core/components/data-table/data-table.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<span class="icon-button-header-wrapper">
<button
id="sortButton"
*ngIf="column.sortable && sortedObserved"
*ngIf="column.sortable"
class="pi"
[class.pi-sort-alt-slash]="(column?.id === sortColumn && sortDirection === 'NONE') || column?.id !== sortColumn"
[class.pi-sort-amount-up]="column?.id === sortColumn && sortDirection === 'ASCENDING'"
Expand Down
6 changes: 0 additions & 6 deletions libs/portal-integration-angular/src/lib/core/components/data-table/data-table.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,12 +145,6 @@ export class DataTableComponent extends DataSortBase implements OnInit {
currentFilterOptions$: Observable<SelectItem[]> | undefined
currentSelectedFilters$: Observable<string[]> | undefined
filterAmounts$: Observable<Record<string, number>> | undefined
get sortedObserved(): boolean {
return this.injector.get('DataViewComponent', null)?.sorted.observed || this.sorted.observed
}
get filteredObserved(): boolean {
return this.injector.get('DataViewComponent', null)?.filtered.observed || this.filtered.observed
}
get viewTableRowObserved(): boolean {
const dv = this.injector.get('DataViewComponent', null)
return dv?.viewItemObserved || dv?.viewItem.observed || this.viewTableRow.observed
Expand Down
Loading