New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dialog service improvements #106

Merged

SchettlerKoehler merged 4 commits into onecx:main from markuczy:feat/dialog-service-improvements

Feb 5, 2024

Contributor

markuczy commented Feb 5, 2024

Adjusted documentation
Allowed to pass in component Type as componentOrMessage parameter
Dialog close observable should now contain latest state of the component
Checked if intellisense is reporting correct DialogState when providing component implementing DialogResult

markuczy added 4 commits

February 5, 2024 08:22


          fix: fixed repeated interface in example docs

e6c59dc


          feat: dialog service returns last updated state of displayed component

de9922f


          feat: dialog service allows providing component type

5e42fba


          feat: adjusted documentation

5cdbbe0

SchettlerKoehler approved these changes

View reviewed changes

SchettlerKoehler merged commit 301273a into onecx:main

1 check passed

github-actions bot pushed a commit that referenced this pull request


          chore(release): -v4.4.0 [skip ci]

2601f2f

## [4.4.0](v4.3.0...v4.4.0) (2024-02-06)

### Features

* add app-state-service mock ([#114](#114)) ([b314e81](b314e81))
* allow specifying icons for header objectDetails ([#101](#101)) ([287d873](287d873))
* dialog service improvements ([#106](#106)) ([301273a](301273a))
* overflow action buttons can be disabled ([#95](#95)) ([6194335](6194335))
* table row selection ([#82](#82)) ([#107](#107)) ([8b14bf7](8b14bf7))

### Bug Fixes

* export app-state-service mock ([#115](#115)) ([60778c0](60778c0))

### Chores

* **deps-dev:** bump jest-environment-jsdom from 29.5.0 to 29.7.0 ([#102](#102)) ([ee60735](ee60735))
* **deps-dev:** bump nx-release from 3.1.6 to 3.3.0 ([#105](#105)) ([6089325](6089325))
* **deps-dev:** bump ts-jest from 29.1.1 to 29.1.2 ([#88](#88)) ([8f4ad86](8f4ad86))
* **deps-dev:** bump ts-node from 10.9.1 to 10.9.2 ([#103](#103)) ([9e43120](9e43120))

### Refactoring

* remove unused getters and broken conditional ([#79](#79)) ([#113](#113)) ([ee32517](ee32517))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet