feat: table row selection #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchettlerKoehler
changed the title
SchettlerKoehler
requested changes
Feb 1, 2024
|
|
||
| mapSelectionToRows() { | ||
| this.selectedRows$ = this._selection$.pipe( |
There was a problem hiding this comment.
Please use combineLatest to make sure the selection is also updated when the rows change
this.selectedRows$ = combineLatest([this._selection$, this._rows$]).pipe(map(([selectedRows, rows]) => {....}))
|
|
||
| beforeEach(async () => { | ||
| component.layout = 'table' | ||
| dataTable = await loader.getHarness(DataTableHarness) |
There was a problem hiding this comment.
Please get the harness from the DataViewHarnes
|
|
||
| beforeEach(async () => { | ||
| dataLayoutSelection = await loader.getHarness(DataLayoutSelectionHarness) | ||
| dataView = await loader.getHarness(DataViewHarness) |
There was a problem hiding this comment.
Please get the harness from the InteractiveDataViewHarness
SchettlerKoehler
approved these changes
Feb 1, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 2, 2024
## [3.10.0](v3.9.0...v3.10.0) (2024-02-02) ### Features * add emitEvents Input ([#99](#99)) ([f63aada](f63aada)), closes [#98](#98) * init v3 branch and add to workflow ([3e24075](3e24075)) * table row selection ([#82](#82)) ([f420cdd](f420cdd)) ### Refactoring * remove unused getters and broken conditional ([#79](#79)) ([8994807](8994807)) * **test:** ocx-content & ocx-content-container test harnesses ([#71](#71)) ([4ab7931](4ab7931))
bastianjakobi
added a commit
to bastianjakobi/onecx-portal-ui-libs
that referenced
this pull request
Feb 5, 2024
* feat: create DataTableComponent storybook entry * feat: basic selection feature for data-table component * feat: connect selection feature to parent components * test: add smoke tests to interactive-data-view * test: add smoke tests to data-view * test: add tests to data-table * refactor: improve data-table tests & harness * fix: use combineLatest instead of withLatestFrom * fix: fix harness loading --------- Co-authored-by: Bastian Jakobi <[email protected]>
bastianjakobi
added a commit
that referenced
this pull request
Feb 6, 2024
* feat: create DataTableComponent storybook entry * feat: basic selection feature for data-table component * feat: connect selection feature to parent components * test: add smoke tests to interactive-data-view * test: add smoke tests to data-view * test: add tests to data-table * refactor: improve data-table tests & harness * fix: use combineLatest instead of withLatestFrom * fix: fix harness loading --------- Co-authored-by: Bastian Jakobi <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
## [4.4.0](v4.3.0...v4.4.0) (2024-02-06) ### Features * add app-state-service mock ([#114](#114)) ([b314e81](b314e81)) * allow specifying icons for header objectDetails ([#101](#101)) ([287d873](287d873)) * dialog service improvements ([#106](#106)) ([301273a](301273a)) * overflow action buttons can be disabled ([#95](#95)) ([6194335](6194335)) * table row selection ([#82](#82)) ([#107](#107)) ([8b14bf7](8b14bf7)) ### Bug Fixes * export app-state-service mock ([#115](#115)) ([60778c0](60778c0)) ### Chores * **deps-dev:** bump jest-environment-jsdom from 29.5.0 to 29.7.0 ([#102](#102)) ([ee60735](ee60735)) * **deps-dev:** bump nx-release from 3.1.6 to 3.3.0 ([#105](#105)) ([6089325](6089325)) * **deps-dev:** bump ts-jest from 29.1.1 to 29.1.2 ([#88](#88)) ([8f4ad86](8f4ad86)) * **deps-dev:** bump ts-node from 10.9.1 to 10.9.2 ([#103](#103)) ([9e43120](9e43120)) ### Refactoring * remove unused getters and broken conditional ([#79](#79)) ([#113](#113)) ([ee32517](ee32517))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.