Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cherry pick table row selection (#82) #107

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

bastianjakobi
Copy link
Contributor

  • feat: create DataTableComponent storybook entry

  • feat: basic selection feature for data-table component

  • feat: connect selection feature to parent components

  • test: add smoke tests to interactive-data-view

  • test: add smoke tests to data-view

  • test: add tests to data-table

  • refactor: improve data-table tests & harness

  • fix: use combineLatest instead of withLatestFrom

  • fix: fix harness loading


* feat: create DataTableComponent storybook entry

* feat: basic selection feature for data-table component

* feat: connect selection feature to parent components

* test: add smoke tests to interactive-data-view

* test: add smoke tests to data-view

* test: add tests to data-table

* refactor: improve data-table tests & harness

* fix: use combineLatest instead of withLatestFrom

* fix: fix harness loading

---------

Co-authored-by: Bastian Jakobi <[email protected]>
@bastianjakobi bastianjakobi self-assigned this Feb 5, 2024
@bastianjakobi bastianjakobi merged commit 8b14bf7 into onecx:main Feb 6, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Feb 6, 2024
## [4.4.0](v4.3.0...v4.4.0) (2024-02-06)

### Features

* add app-state-service mock ([#114](#114)) ([b314e81](b314e81))
* allow specifying icons for header objectDetails ([#101](#101)) ([287d873](287d873))
* dialog service improvements ([#106](#106)) ([301273a](301273a))
* overflow action buttons can be disabled ([#95](#95)) ([6194335](6194335))
* table row selection ([#82](#82)) ([#107](#107)) ([8b14bf7](8b14bf7))

### Bug Fixes

* export app-state-service mock ([#115](#115)) ([60778c0](60778c0))

### Chores

* **deps-dev:** bump jest-environment-jsdom from 29.5.0 to 29.7.0 ([#102](#102)) ([ee60735](ee60735))
* **deps-dev:** bump nx-release from 3.1.6 to 3.3.0 ([#105](#105)) ([6089325](6089325))
* **deps-dev:** bump ts-jest from 29.1.1 to 29.1.2 ([#88](#88)) ([8f4ad86](8f4ad86))
* **deps-dev:** bump ts-node from 10.9.1 to 10.9.2 ([#103](#103)) ([9e43120](9e43120))

### Refactoring

* remove unused getters and broken conditional ([#79](#79)) ([#113](#113)) ([ee32517](ee32517))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant