fix: shell translations for MFEs and RCs (#564)

* fix: portal-integration-angular translations from shell included in mfes * fix: shell translations for remote components * fix: fix tests
onecx · Oct 28, 2024 · f5f3ff6 · f5f3ff6
1 parent eb78d52
commit f5f3ff6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/libs/angular-accelerator/src/lib/utils/create-remote-component-translate-loader.utils.ts b/libs/angular-accelerator/src/lib/utils/create-remote-component-translate-loader.utils.ts
@@ -32,6 +32,8 @@ export function createRemoteComponentTranslateLoader(
             Location.joinWithSlash(baseUrl, `onecx-portal-lib/assets/i18n/`),
             '.json'
           ),
+          // translations of portal-integration-angular of shell
+          new CachingTranslateLoader(ts, http, `./onecx-portal-lib/assets/i18n/`, '.json'),
           // translations of the app
           new CachingTranslateLoader(ts, http, Location.joinWithSlash(baseUrl, `assets/i18n/`), '.json')
         )

diff --git a/libs/angular-accelerator/src/lib/utils/create-translate-loader.utils.spec.ts b/libs/angular-accelerator/src/lib/utils/create-translate-loader.utils.spec.ts
@@ -40,7 +40,7 @@ describe('CreateTranslateLoader', () => {
       )
 
       translateLoader.getTranslation('en').subscribe(() => {
-        expect(httpClientMock.get).toHaveBeenCalledTimes(4)
+        expect(httpClientMock.get).toHaveBeenCalledTimes(5)
         done()
       })
     })
@@ -70,7 +70,7 @@ describe('CreateTranslateLoader', () => {
       )
 
       translateLoader.getTranslation('en').subscribe(() => {
-        expect(httpClientMock.get).toHaveBeenCalledTimes(4)
+        expect(httpClientMock.get).toHaveBeenCalledTimes(5)
         done()
       })
     })

diff --git a/libs/angular-accelerator/src/lib/utils/create-translate-loader.utils.ts b/libs/angular-accelerator/src/lib/utils/create-translate-loader.utils.ts
@@ -34,6 +34,8 @@ export function createTranslateLoader(
             Location.joinWithSlash(currentMfe.remoteBaseUrl, `onecx-portal-lib/assets/i18n/`),
             '.json'
           ),
+          // translations of portal-integration-angular of shell
+          new CachingTranslateLoader(ts, http, `./onecx-portal-lib/assets/i18n/`, '.json'),
           // Primelocale Translations
           new CachingTranslateLoader(
             ts,