feat: update operator rest api

onecx · Jan 5, 2024 · ea101c2 · ea101c2
1 parent d5f9da3
commit ea101c2
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 12 deletions.
diff --git a/...in/java/io/github/onecx/permission/rs/operator/v1/controllers/OperatorRestController.java b/...in/java/io/github/onecx/permission/rs/operator/v1/controllers/OperatorRestController.java
@@ -38,6 +38,9 @@ public class OperatorRestController implements PermissionOperatorApi {
     public Response createOrUpdatePermission(String appId, PermissionRequestDTOV1 permissionRequestDTOV1) {
 
         var data = mapper.map(permissionRequestDTOV1, appId);
+        if (data.isEmpty()) {
+            return Response.ok().build();
+        }
         var permissions = dao.loadByAppId(appId);
         var map = permissions.stream().collect(Collectors.toMap(x -> x.getObject() + x.getAction(), x -> x));
 

diff --git a/...main/java/io/github/onecx/permission/rs/operator/v1/mappers/OperatorPermissionMapper.java b/...main/java/io/github/onecx/permission/rs/operator/v1/mappers/OperatorPermissionMapper.java
@@ -19,7 +19,7 @@ default List<Permission> map(PermissionRequestDTOV1 dto, String appId) {
 
     default List<Permission> map(List<PermissionDTOV1> list, String appId) {
         if (list == null) {
-            return null;
+            return List.of();
         }
         List<Permission> data = new ArrayList<>();
         for (PermissionDTOV1 dto : list) {

diff --git a/src/main/openapi/onecx-permission-operator-v1.yaml b/src/main/openapi/onecx-permission-operator-v1.yaml
@@ -43,7 +43,6 @@ components:
       properties:
         permissions:
           type: array
-          minItems: 1
           items:
             $ref: '#/components/schemas/Permission'
     Permission:

diff --git a/...ava/io/github/onecx/permission/rs/operator/v1/controllers/OperatorRestControllerTest.java b/...ava/io/github/onecx/permission/rs/operator/v1/controllers/OperatorRestControllerTest.java
@@ -22,7 +22,7 @@
 @QuarkusTest
 @TestHTTPEndpoint(OperatorRestController.class)
 @WithDBData(value = "data/test-operator-v1.xml", deleteBeforeInsert = true, deleteAfterTest = true, rinseAndRepeat = true)
-public class OperatorRestControllerTest extends AbstractTest {
+class OperatorRestControllerTest extends AbstractTest {
 
     @Test
     void requestNoBodyTest() {
@@ -46,21 +46,14 @@ void requestEmptyListTest() {
         var request = new PermissionRequestDTOV1();
         request.setPermissions(List.of());
 
-        var exception = given()
+        given()
                 .contentType(APPLICATION_JSON)
                 .body(request)
                 .pathParam("appId", "app1")
                 .put()
                 .then()
-                .statusCode(BAD_REQUEST.getStatusCode())
-                .contentType(APPLICATION_JSON)
-                .extract()
-                .as(ProblemDetailResponseDTOV1.class);
+                .statusCode(OK.getStatusCode());
 
-        assertThat(exception).isNotNull();
-        assertThat(exception.getErrorCode()).isEqualTo(ExceptionMapper.ErrorKeys.CONSTRAINT_VIOLATIONS.name());
-        assertThat(exception.getDetail()).isEqualTo(
-                "createOrUpdatePermission.permissionRequestDTOV1.permissions: size must be between 1 and 2147483647");
     }
 
     @Test