fix: fine tuning list bookmarks (#181)

* fix: fine tuning list bookmarks * fix: try to fix code smell
onecx · Jan 13, 2025 · 11e1a3e · 11e1a3e
1 parent 2abdae3
commit 11e1a3e
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 13 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -1,4 +1,4 @@
-FROM ghcr.io/onecx/docker-spa-base:1.9.0
+FROM ghcr.io/onecx/docker-spa-base:1.10.0
 
 # Copy nginx configuration
 COPY nginx/locations.conf $DIR_LOCATION/locations.conf

diff --git a/src/app/bookmark/bookmark-search/bookmark-search.component.html b/src/app/bookmark/bookmark-search/bookmark-search.component.html
@@ -1,8 +1,4 @@
-<ocx-portal-page
-  permission="BOOKMARK#VIEW"
-  helpArticleId="PAGE_BOOKMARK_SEARCH"
-  *ngrxLet="viewModel$ as vm; error as err; complete as done"
->
+<ocx-portal-page permission="BOOKMARK#VIEW" helpArticleId="PAGE_BOOKMARK_SEARCH" *ngrxLet="viewModel$ as vm">
   <ocx-page-header
     [header]="'BOOKMARK_SEARCH.HEADER' | translate"
     [subheader]="'BOOKMARK_SEARCH.SUB_HEADER' | translate"

diff --git a/src/app/bookmark/bookmark-search/bookmark-search.effects.ts b/src/app/bookmark/bookmark-search/bookmark-search.effects.ts
@@ -156,9 +156,10 @@ export class BookmarkSearchEffects {
       )
     }
     const saveAction = (editable: boolean) => {
-      return editable
+      const button = editable
         ? { key: 'ACTIONS.SAVE', icon: PrimeIcons.SAVE }
         : { key: 'ACTIONS.NAVIGATION.CLOSE', icon: PrimeIcons.TIMES }
+      return button
     }
     return this.actions$.pipe(
       ofType(BookmarkSearchActions.viewOrEditBookmark),

diff --git a/src/app/remotes/bookmark-list/bookmark-links/bookmark-links.component.html b/src/app/remotes/bookmark-list/bookmark-links/bookmark-links.component.html
@@ -1,4 +1,4 @@
-<div class="p-1 flex flex-column gap-1 max-h-16rem overflow-auto">
+<div class="p-1 flex flex-column gap-1 max-h-17rem overflow-auto">
   @for (bookmark of bookmarks; track $index) {
   <a [routerLink]="getUrl(bookmark) | async" class="mt-1 p-1 border-round bookmark-link font-italic text-primary">
     {{ bookmark.displayName }}

diff --git a/src/app/remotes/bookmark-list/bookmark-list.component.html b/src/app/remotes/bookmark-list/bookmark-list.component.html
@@ -1,5 +1,5 @@
-<div class="card min-height-10rem surface-200">
-  <div class="mb-3 font-medium text-lg">{{'REMOTES.BOOKMARK_LIST.TITLE' | translate}}</div>
+<div class="card surface-200">
+  <div class="mb-2 sm:mb-3 font-medium text-lg">{{'REMOTES.BOOKMARK_LIST.TITLE' | translate}}</div>
 
   <p-tabView *ngIf="!bookmarkLoadingError && !loading; else loadingSpinner">
     <p-tabPanel

diff --git a/src/app/remotes/bookmark-list/bookmark-list.component.scss b/src/app/remotes/bookmark-list/bookmark-list.component.scss
@@ -3,13 +3,15 @@
 @include tabview-fix-color-selected-tab;
 
 :host ::ng-deep {
-  .p-tabview .p-tabview-panels {
-    padding: 0.3rem 0 0 0;
+  .p-tabview {
+    .p-tabview-panels {
+      padding: 0.3rem 0 0 0;
+    }
   }
 
   .p-tabview-nav-container,
   .p-tabview-nav-link,
   .p-tabview-panels {
-    background-color: var(--surface-200) !important;
+    background-color: inherit !important;
   }
 }