webcomponent migration #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 11, 2024 21:53
markuczy
reviewed
Sep 13, 2024
Comment on lines
+41
to
44
| export function withModuleFederationPlugin(arg0: { exposes: any }) { | ||
| throw new Error('Function not implemented.'); | ||
| } | ||
| export function apiConfigProvider( |
| }, | ||
| { | ||
| path: 'search', | ||
| matcher: startsWith('search'), |
There was a problem hiding this comment.
With this change you are removing possibility to access DocumentSearchModule via empty path. You should do the following:
{
matcher: startsWith(''),
redirectTo: 'search',
pathMatch: 'full',
},| filename: 'remoteEntry.js', | ||
| exposes: { | ||
| './DocumentRemoteModule': './src/app/remote.module.ts', | ||
| './DocumentRemoteModule': 'src/bootstrap.ts', |
There was a problem hiding this comment.
You should use 'src/main.ts file here
| @@ -58,8 +59,55 @@ const config = withModuleFederationPlugin({ | |||
| requiredVersion: 'auto', | |||
| includeSecondaries: true, | |||
| }, | |||
| '@onecx/angular-auth': { | |||
There was a problem hiding this comment.
You should make sure that every package form package-lock.json starting with @onecx/* is shared. I think @onecx/angular-accelerator is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.