init web tests #372
Merged
init web tests #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredbi
reviewed
Jan 28, 2020
ransomw1c
force-pushed
the
j1599-webtest--wip
branch
5 times, most recently
from
925241b to
56727e0
Compare
ransomw1c
force-pushed
the
j1599-webtest--wip
branch
from
56727e0 to
2059d51
Compare
|
the mocks setup here isn't particularly fleshed out.. in the interest of time, in the ignorance of apis. would be happy to add a little more here for the sake of learning how to use mocks (incl. generated mocks) better. i suppose this is alright towards the goals of the issue/description? |
fredbi
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
@ransomw1c just out of curiosity, how does this fare regarding the coverage metrics?
Open
ransomw1c
force-pushed
the
j1599-webtest--wip
branch
from
2059d51 to
bde1a6d
Compare
Signed-off-by: Ransom Williams <[email protected]>
ransomw1c
force-pushed
the
j1599-webtest--wip
branch
from
2af9742 to
e915dc4
Compare
they're ok, i guess? https://4394-138348481-gh.circle-artifacts.com/0/coverage-report/coverage_non_cafs.html#file82 the main omission is tests error-handling, as mentioned in the comments. #377 can include such tests? |
Signed-off-by: Ransom Williams <[email protected]>
ransomw1c
force-pushed
the
j1599-webtest--wip
branch
from
2238a57 to
7d7e38f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start smoke tests on
pkg/web.specifically, the goal here is to land a demo of how to test the
chirouter used to implement the web front.notice in particular that
pkg/web's import ofpkg/coreis mocked out in test in order to test the web server implementation.