You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewers comments from #368, left as TODOs, in a nutshell:
Confusing/pointless use of type alias for bool
My point was just to replace this by: func MultiPut(ctx context.Context, stores []MultiStoreUnit, name string, buffer []byte, doesNotExist bool) error
separate porcelain funcs from cmd
refactor types defining such dsl-ish things to a separate package
Yes. Indeed this is the goal I am pursuing. I'd like many little things like this (including the whole flagsT, with default settings and GCS strategy) to move to some pkg/api/helpers or pkg/sdk/helpers package to be available as an higher level API for instance, a python wrapper. Please suggest a name for that.
Removed aliased type to bool.
Go aliased types (i.e. type A = B) are a syntactic sugar only.
This is different from type redefinitions (i.e. type A B), which create a new type for the compiler.
The original intent was to construct some kind of enumerated type, for a... boolean.
I chose to remove all this and just go back to plain bool.
* contributes #374
Signed-off-by: Frederic BIDON <[email protected]>
* Moved up logLevel param to be at the root level.
* Added a "none" level to mute zap logging entirely
* contributes #374
Signed-off-by: Frederic BIDON <[email protected]>
* Moved up logLevel param to be at the root level.
* Added a "none" level to mute zap logging entirely
* contributes #374
Signed-off-by: Frederic BIDON <[email protected]>
Co-authored-by: Ritesh H Shukla <[email protected]>
Reviewers comments from #368, left as TODOs, in a nutshell:
func localPath(consumable fmt.Stringer) (string, error)
func testContext() string
cruft?
The text was updated successfully, but these errors were encountered: