[L0] Use zesInit for SysMan API usage #1886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrspruit
force-pushed
the
l0_sysman_default
branch
from
1d3b02d to
e83ec51
Compare
nrspruit
force-pushed
the
l0_sysman_default
branch
6 times, most recently
from
cee662a to
810cf5d
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jul 24, 2024
-pre-commit PR for oneapi-src/unified-runtime#1886 Signed-off-by: Neil R. Spruit <[email protected]>
- Change to using zesInit and zes data structures for accessing L0 SysMan functionality. - Updated Platform & Devices to store zes handles if sysman support is available. - Given Legacy Environment Variable from user, then fallback to old functionality. - Fixed Return code on error to be consistently unsupported enumeration. Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
l0_sysman_default
branch
from
810cf5d to
dbdc7e7
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jul 24, 2024
-pre-commit PR for oneapi-src/unified-runtime#1886 Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jul 24, 2024
-pre-commit PR for oneapi-src/unified-runtime#1886 Signed-off-by: Neil R. Spruit <[email protected]>
aravindksg
reviewed
Jul 25, 2024
| uint32_t ZeDriverCount = 0; | ||
| ZE2UR_CALL(zeDriverGet, (&ZeDriverCount, nullptr)); | ||
| if (ZeDriverCount == 0) { | ||
| return UR_RESULT_SUCCESS; | ||
| } | ||
|
|
||
| uint32_t ZesDriverCount = 0; | ||
| ze_result_t zesDriverGetResult = ZE_RESULT_ERROR_UNINITIALIZED; |
There was a problem hiding this comment.
zesinit/zesDriverGet was introduced from v1.5 onwards IIRC, so do we need a way to check version here before call zesDriverGet?
| // then a null sysman driver is associated. The index of the ZE and ZES | ||
| // driver should match. | ||
| if (I < ZesDrivers.size()) { | ||
| zesDriverHandle = ZesDrivers[I]; |
There was a problem hiding this comment.
hmm how can we be sure the drivers are enumerated in same order? but having said that i see core driver_properties at least provide a a driver_uuid but Sysman does not have that.
| @@ -304,14 +304,30 @@ ur_result_t ur_platform_handle_t_::populateDeviceCacheIfNeeded() { | |||
|
|
|||
| uint32_t ZeDeviceCount = 0; | |||
| ZE2UR_CALL(zeDeviceGet, (ZeDriver, &ZeDeviceCount, nullptr)); | |||
| uint32_t ZesDeviceCount = 0; | |||
| if (ZesDriver) { | |||
| ZE2UR_CALL(zesDeviceGet, (ZesDriver, &ZesDeviceCount, nullptr)); | |||
There was a problem hiding this comment.
we might again need version check before calling zesDeviceGet to make sure we have support?
| // then a null sysman device is associated. The index of the ZE and ZES | ||
| // devices should match. | ||
| if (I < ZesDevices.size()) { | ||
| zesDeviceHandle = ZesDevices[I]; |
There was a problem hiding this comment.
do we need to match uuid here between core and sysman devices before association here? or you are not doing that for now since it was a very recent change in UMD?
|
replaced by #2017 which itself is awaiting a patch for dynamic dependency loading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SysMan functionality.
available.
old functionality.