Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: update bazel oneMKL deps #2965

Merged
merged 3 commits into from
Nov 4, 2024
Merged

dev: update bazel oneMKL deps #2965

merged 3 commits into from
Nov 4, 2024

Conversation

Alexandr-Solovev
Copy link
Contributor

@Alexandr-Solovev Alexandr-Solovev commented Oct 31, 2024 •
edited
Loading

Description

PR introduces updated versions of dependencies in Bazel WORKSPACE file. All deps have been updated to oneAPI 2025.0 release.

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

Performance

  • I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
  • I have provided justification why performance has changed or why changes are not expected.
  • I have provided justification why quality metrics have changed or why changes are not expected.
  • I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

@Alexandr-Solovev Alexandr-Solovev added the dependencies Pull requests that update a dependency file label Oct 31, 2024
@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev Alexandr-Solovev marked this pull request as ready for review November 4, 2024 11:04
@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

ethanglaser
ethanglaser approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@ethanglaser ethanglaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alexandr-Solovev Alexandr-Solovev merged commit 3999b20 into oneapi-src:main Nov 4, 2024
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanglaser ethanglaser ethanglaser approved these changes

@icfaust icfaust icfaust approved these changes

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss is a code owner

@napetrov napetrov Awaiting requested review from napetrov napetrov is a code owner

@homksei homksei Awaiting requested review from homksei homksei is a code owner

@ahuber21 ahuber21 Awaiting requested review from ahuber21 ahuber21 is a code owner

@Vika-F Vika-F Awaiting requested review from Vika-F

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexandr-Solovev @icfaust @ethanglaser