class definition in daal_atomic_int.h #2
Comments
|
And I think the following definitions of |
|
Changes added to daal_2017_update1 branch. Thank you |
michael-smirnov
pushed a commit
to michael-smirnov/oneDAL
that referenced
this issue
Jan 24, 2020
Add draft numeric tables
dr-pain
pushed a commit
to dr-pain/daal
that referenced
this issue
Feb 25, 2020
dr-pain
pushed a commit
to dr-pain/daal
that referenced
this issue
Apr 20, 2020
dr-pain
pushed a commit
to dr-pain/daal
that referenced
this issue
Apr 21, 2020
KulikovNikita
pushed a commit
to KulikovNikita/daal
that referenced
this issue
Jun 30, 2020
amgrigoriev
referenced
this issue
in amgrigoriev/daal
Oct 4, 2020
amgrigoriev
referenced
this issue
in amgrigoriev/daal
Oct 11, 2020
amgrigoriev
referenced
this issue
in amgrigoriev/daal
Apr 16, 2021
YakhtinLeonid
pushed a commit
to YakhtinLeonid/oneDAL
that referenced
this issue
May 13, 2021
Badargs and correctness unit-tests
averbukh
pushed a commit
to averbukh/oneDAL
that referenced
this issue
Jun 2, 2021
averbukh
pushed a commit
that referenced
this issue
Jun 3, 2021
* Experiment to address infinite loop * Experiment #2 to address infinite loop * Experiment #3 to address infinite loop * Temporary debug output added * External limit for number of threads was removed * Experiment #4 to address infinite loop * Experiment #5 to address infinite loop * Experiment #6 to address infinite loop * Experiment #7 to address infinite loop * Experiment #8 to address infinite loop * 20% is set as optimal value * Temporary code removed * Optimal array_size is caclulated based on max thread count * Optimal array_size is decreased * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Experiment #9 to address infinite loop * Optimal array_size is adjusted * Temporary debug output added * Compilation fix * Experiment #10 to address infinite loop * Temporary debug output added * Experiment #11 to address infinite loop * Temporary code removed * Optimal array_size is adjusted
averbukh
pushed a commit
that referenced
this issue
Jun 3, 2021
* Experiment to address infinite loop * Experiment #2 to address infinite loop * Experiment #3 to address infinite loop * Temporary debug output added * External limit for number of threads was removed * Experiment #4 to address infinite loop * Experiment #5 to address infinite loop * Experiment #6 to address infinite loop * Experiment #7 to address infinite loop * Experiment #8 to address infinite loop * 20% is set as optimal value * Temporary code removed * Optimal array_size is caclulated based on max thread count * Optimal array_size is decreased * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Optimal array_size is adjusted * Experiment #9 to address infinite loop * Optimal array_size is adjusted * Temporary debug output added * Compilation fix * Experiment #10 to address infinite loop * Temporary debug output added * Experiment #11 to address infinite loop * Temporary code removed * Optimal array_size is adjusted
amgrigoriev
referenced
this issue
in amgrigoriev/daal
Dec 9, 2021
amgrigoriev
added a commit
that referenced
this issue
Dec 15, 2021
amgrigoriev
referenced
this issue
in amgrigoriev/daal
Jul 14, 2023
KulikovNikita
pushed a commit
to KulikovNikita/daal
that referenced
this issue
Aug 2, 2023
…_appr removed config_template auxiliary func
napetrov
added a commit
that referenced
this issue
Aug 25, 2023
* Initial input for backend selection * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <[email protected]> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <[email protected]> * Changed default backend to 'mkl' * Buildable onedal_c * Added clang support * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <[email protected]> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <[email protected]> * Compiler fixes for icc, icx, vc plus clang-format * Update dev/make/cmplr.clang.ref.mk Co-authored-by: KulikovNikita <[email protected]> * adding support for selecting different math/rng/service backends in case of build with bazel * fixed build issue with kmeans serialization * Introducing backend_config param selection to build.sh * Create openblas.sh * Introduce CI build for BLAS backend * adding execute permission on openblas.sh * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <[email protected]> * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <[email protected]> * Addressed part of the comments * Clang-format * Turned off hyperthreadig for ref config in order to use TBB default number of threads * Addressed more comments * Macro fixed (APPLE) * More changes in REF RNG * Update build.sh * Removed 'sed' from Makefile * Update openblas.sh * Removed config_template from BAZEL * Removed backend_config_header from BAZEL * Update openblas.sh * Replaced safe function not supported by GNU * Fixed bugs in ref backend for OpenBLAS build * Fixed bugs in ref backend for OpenBLAS build #2 * Reduced header file dependencies in REF backend; removed << operator for RNG (compiling issue) * Update ci.yml * Fixed export on symbols for OpenBLAS build * export.def handling in bazel * Update cpp/daal/src/externals/service_math_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Added libfgortran to REF build * removed config_template auxiliary func * Removed libgfortran for REF backend * Fixed BACKEND incdirs for oneAPI; addressed some comments * Removed unnecessary includes; fixed ifdef in _DECLAR_ files * fixed omitted ifdef in _DECLAR_ files * Clang-format * Clang-format fix * Added an option to move compression to exclude list for examples * Excluded compression examples for all configurations * revert some macros to __intel_compiler * replase some more macros * add NO_FORTRAN=1 to openblas.sh script * Update cpp/daal/src/externals/service_service_ref.h * Fixed missed fpk symbols for oneapi examples (REF backend) * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Fixed error message in oneapi * exclude failed examples with ref backend * exclude examples for oneapi/cpp ifaces * exclude mpi examples for ref backend * Apply suggestions from code review * AVX512_MIC cleanup * Fixed CI pipeline * Added more includes for ONEAPI * Update .ci/pipeline/ci.yml * Switch to core count for blas build * Update .ci/env/openblas.sh * Adding _MKL suffix for job name * Fixing daal4py job dependency * Attempt to fix warnings --------- Co-authored-by: Aleksey Grigorev <[email protected]> Co-authored-by: KulikovNikita <[email protected]> Co-authored-by: a.maklaev <[email protected]> Co-authored-by: Nikolay Petrov <[email protected]> Co-authored-by: Victoriya Fedotova <[email protected]> Co-authored-by: Pavel Yakovlev <[email protected]> Co-authored-by: Pavel Yakovlev <[email protected]>
KulikovNikita
pushed a commit
to KulikovNikita/daal
that referenced
this issue
Aug 26, 2023
* Initial input for backend selection * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <[email protected]> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <[email protected]> * Changed default backend to 'mkl' * Buildable onedal_c * Added clang support * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <[email protected]> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <[email protected]> * Compiler fixes for icc, icx, vc plus clang-format * Update dev/make/cmplr.clang.ref.mk Co-authored-by: KulikovNikita <[email protected]> * adding support for selecting different math/rng/service backends in case of build with bazel * fixed build issue with kmeans serialization * Introducing backend_config param selection to build.sh * Create openblas.sh * Introduce CI build for BLAS backend * adding execute permission on openblas.sh * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <[email protected]> * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <[email protected]> * Addressed part of the comments * Clang-format * Turned off hyperthreadig for ref config in order to use TBB default number of threads * Addressed more comments * Macro fixed (APPLE) * More changes in REF RNG * Update build.sh * Removed 'sed' from Makefile * Update openblas.sh * Removed config_template from BAZEL * Removed backend_config_header from BAZEL * Update openblas.sh * Replaced safe function not supported by GNU * Fixed bugs in ref backend for OpenBLAS build * Fixed bugs in ref backend for OpenBLAS build oneapi-src#2 * Reduced header file dependencies in REF backend; removed << operator for RNG (compiling issue) * Update ci.yml * Fixed export on symbols for OpenBLAS build * export.def handling in bazel * Update cpp/daal/src/externals/service_math_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Added libfgortran to REF build * removed config_template auxiliary func * Removed libgfortran for REF backend * Fixed BACKEND incdirs for oneAPI; addressed some comments * Removed unnecessary includes; fixed ifdef in _DECLAR_ files * fixed omitted ifdef in _DECLAR_ files * Clang-format * Clang-format fix * Added an option to move compression to exclude list for examples * Excluded compression examples for all configurations * revert some macros to __intel_compiler * replase some more macros * add NO_FORTRAN=1 to openblas.sh script * Update cpp/daal/src/externals/service_service_ref.h * Fixed missed fpk symbols for oneapi examples (REF backend) * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Fixed error message in oneapi * exclude failed examples with ref backend * exclude examples for oneapi/cpp ifaces * exclude mpi examples for ref backend * Apply suggestions from code review * AVX512_MIC cleanup * Fixed CI pipeline * Added more includes for ONEAPI * Update .ci/pipeline/ci.yml * Switch to core count for blas build * Update .ci/env/openblas.sh * Adding _MKL suffix for job name * Fixing daal4py job dependency * Attempt to fix warnings --------- Co-authored-by: Aleksey Grigorev <[email protected]> Co-authored-by: KulikovNikita <[email protected]> Co-authored-by: a.maklaev <[email protected]> Co-authored-by: Nikolay Petrov <[email protected]> Co-authored-by: Victoriya Fedotova <[email protected]> Co-authored-by: Pavel Yakovlev <[email protected]> Co-authored-by: Pavel Yakovlev <[email protected]>
KulikovNikita
pushed a commit
to KulikovNikita/daal
that referenced
this issue
Aug 29, 2023
* Initial input for backend selection * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <[email protected]> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <[email protected]> * Changed default backend to 'mkl' * Buildable onedal_c * Added clang support * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <[email protected]> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <[email protected]> * Compiler fixes for icc, icx, vc plus clang-format * Update dev/make/cmplr.clang.ref.mk Co-authored-by: KulikovNikita <[email protected]> * adding support for selecting different math/rng/service backends in case of build with bazel * fixed build issue with kmeans serialization * Introducing backend_config param selection to build.sh * Create openblas.sh * Introduce CI build for BLAS backend * adding execute permission on openblas.sh * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <[email protected]> * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <[email protected]> * Addressed part of the comments * Clang-format * Turned off hyperthreadig for ref config in order to use TBB default number of threads * Addressed more comments * Macro fixed (APPLE) * More changes in REF RNG * Update build.sh * Removed 'sed' from Makefile * Update openblas.sh * Removed config_template from BAZEL * Removed backend_config_header from BAZEL * Update openblas.sh * Replaced safe function not supported by GNU * Fixed bugs in ref backend for OpenBLAS build * Fixed bugs in ref backend for OpenBLAS build oneapi-src#2 * Reduced header file dependencies in REF backend; removed << operator for RNG (compiling issue) * Update ci.yml * Fixed export on symbols for OpenBLAS build * export.def handling in bazel * Update cpp/daal/src/externals/service_math_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Added libfgortran to REF build * removed config_template auxiliary func * Removed libgfortran for REF backend * Fixed BACKEND incdirs for oneAPI; addressed some comments * Removed unnecessary includes; fixed ifdef in _DECLAR_ files * fixed omitted ifdef in _DECLAR_ files * Clang-format * Clang-format fix * Added an option to move compression to exclude list for examples * Excluded compression examples for all configurations * revert some macros to __intel_compiler * replase some more macros * add NO_FORTRAN=1 to openblas.sh script * Update cpp/daal/src/externals/service_service_ref.h * Fixed missed fpk symbols for oneapi examples (REF backend) * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Fixed error message in oneapi * exclude failed examples with ref backend * exclude examples for oneapi/cpp ifaces * exclude mpi examples for ref backend * Apply suggestions from code review * AVX512_MIC cleanup * Fixed CI pipeline * Added more includes for ONEAPI * Update .ci/pipeline/ci.yml * Switch to core count for blas build * Update .ci/env/openblas.sh * Adding _MKL suffix for job name * Fixing daal4py job dependency * Attempt to fix warnings --------- Co-authored-by: Aleksey Grigorev <[email protected]> Co-authored-by: KulikovNikita <[email protected]> Co-authored-by: a.maklaev <[email protected]> Co-authored-by: Nikolay Petrov <[email protected]> Co-authored-by: Victoriya Fedotova <[email protected]> Co-authored-by: Pavel Yakovlev <[email protected]> Co-authored-by: Pavel Yakovlev <[email protected]>
md-shafiul-alam
added a commit
that referenced
this issue
Sep 1, 2023
* Fix incorrect include in service_hash_table.h file * Add initial implementation of the base algorithm::Hyperparameter class * clang-format * Add Hyperparameter* _hpar field into base Algorithm and AlgorithmContainer classes * Implement initial version of Hyperparameters class for Covariance algorithm in DAAL * Extend covariance::BatchImpl (and thus covariance::Batch) interface with the Hyperparameter support * Remove outdated verionst of setArgument methods * Add ability to pass hyperparameters from DAAL API to kernels in Covariance algorithm * 1. Make the hyperparameter field of DAAL Algorithm class constant. 2. Implement passing hyperparameters from oneDAL to DAAL on CPU * Fix * Fix Java build * Move covariance::Hyperparameter class to covariance::internal namespace * Removal of compression functionality (#2462) * Temporary disabling gemv test (#2463) * AVX/SSSE3/AVX512_MIC ISA cleanup (#2465) * cleanup avx512_mic * cleanup ssse3 * cleanup avx * fixing typos * fixing / typos * fixing make typos * clang format * Updating ISA in install.md * replace AVX with AVX2 for intersect * Remove mention of compression in docs (#2467) * Init addition of online interfaces in Covariance (#2455) * Add the link to oneAPI samples browser (#2470) * infra: update binary version (#2468) * update binary version * more binary version updates * Initial input for backend selection (#2396) * Initial input for backend selection * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <[email protected]> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <[email protected]> * Changed default backend to 'mkl' * Buildable onedal_c * Added clang support * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <[email protected]> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <[email protected]> * Compiler fixes for icc, icx, vc plus clang-format * Update dev/make/cmplr.clang.ref.mk Co-authored-by: KulikovNikita <[email protected]> * adding support for selecting different math/rng/service backends in case of build with bazel * fixed build issue with kmeans serialization * Introducing backend_config param selection to build.sh * Create openblas.sh * Introduce CI build for BLAS backend * adding execute permission on openblas.sh * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <[email protected]> * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <[email protected]> * Addressed part of the comments * Clang-format * Turned off hyperthreadig for ref config in order to use TBB default number of threads * Addressed more comments * Macro fixed (APPLE) * More changes in REF RNG * Update build.sh * Removed 'sed' from Makefile * Update openblas.sh * Removed config_template from BAZEL * Removed backend_config_header from BAZEL * Update openblas.sh * Replaced safe function not supported by GNU * Fixed bugs in ref backend for OpenBLAS build * Fixed bugs in ref backend for OpenBLAS build #2 * Reduced header file dependencies in REF backend; removed << operator for RNG (compiling issue) * Update ci.yml * Fixed export on symbols for OpenBLAS build * export.def handling in bazel * Update cpp/daal/src/externals/service_math_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Added libfgortran to REF build * removed config_template auxiliary func * Removed libgfortran for REF backend * Fixed BACKEND incdirs for oneAPI; addressed some comments * Removed unnecessary includes; fixed ifdef in _DECLAR_ files * fixed omitted ifdef in _DECLAR_ files * Clang-format * Clang-format fix * Added an option to move compression to exclude list for examples * Excluded compression examples for all configurations * revert some macros to __intel_compiler * replase some more macros * add NO_FORTRAN=1 to openblas.sh script * Update cpp/daal/src/externals/service_service_ref.h * Fixed missed fpk symbols for oneapi examples (REF backend) * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Fixed error message in oneapi * exclude failed examples with ref backend * exclude examples for oneapi/cpp ifaces * exclude mpi examples for ref backend * Apply suggestions from code review * AVX512_MIC cleanup * Fixed CI pipeline * Added more includes for ONEAPI * Update .ci/pipeline/ci.yml * Switch to core count for blas build * Update .ci/env/openblas.sh * Adding _MKL suffix for job name * Fixing daal4py job dependency * Attempt to fix warnings --------- Co-authored-by: Aleksey Grigorev <[email protected]> Co-authored-by: KulikovNikita <[email protected]> Co-authored-by: a.maklaev <[email protected]> Co-authored-by: Nikolay Petrov <[email protected]> Co-authored-by: Victoriya Fedotova <[email protected]> Co-authored-by: Pavel Yakovlev <[email protected]> Co-authored-by: Pavel Yakovlev <[email protected]> * resolve merge conflict while rebasing in Fix incorrect include in service_hash_table.h file * Add ability to pass hyperparameters from DAAL API to kernels in Covariance algorithm * minor * update examples * clang-format * minor --------- Co-authored-by: Alexander Andreev <[email protected]> Co-authored-by: ethanglaser <[email protected]> Co-authored-by: Nikolay Petrov <[email protected]> Co-authored-by: Aleksandr Solovev <[email protected]> Co-authored-by: Alexandra <[email protected]> Co-authored-by: amgrigoriev <[email protected]> Co-authored-by: Aleksey Grigorev <[email protected]> Co-authored-by: KulikovNikita <[email protected]> Co-authored-by: a.maklaev <[email protected]> Co-authored-by: Pavel Yakovlev <[email protected]> Co-authored-by: Pavel Yakovlev <[email protected]> Co-authored-by: Md Shafiul Alam <[email protected]> Co-authored-by: msa <[email protected]>
KulikovNikita
pushed a commit
to KulikovNikita/daal
that referenced
this issue
Sep 1, 2023
* Initial input for backend selection * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <[email protected]> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <[email protected]> * Changed default backend to 'mkl' * Buildable onedal_c * Added clang support * Update dev/make/cmplr.gnu.mkl.mk Co-authored-by: KulikovNikita <[email protected]> * Update dev/make/cmplr.gnu.ref.mk Co-authored-by: KulikovNikita <[email protected]> * Compiler fixes for icc, icx, vc plus clang-format * Update dev/make/cmplr.clang.ref.mk Co-authored-by: KulikovNikita <[email protected]> * adding support for selecting different math/rng/service backends in case of build with bazel * fixed build issue with kmeans serialization * Introducing backend_config param selection to build.sh * Create openblas.sh * Introduce CI build for BLAS backend * adding execute permission on openblas.sh * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <[email protected]> * Update cpp/daal/src/externals/config_ref.h Co-authored-by: Victoriya Fedotova <[email protected]> * Addressed part of the comments * Clang-format * Turned off hyperthreadig for ref config in order to use TBB default number of threads * Addressed more comments * Macro fixed (APPLE) * More changes in REF RNG * Update build.sh * Removed 'sed' from Makefile * Update openblas.sh * Removed config_template from BAZEL * Removed backend_config_header from BAZEL * Update openblas.sh * Replaced safe function not supported by GNU * Fixed bugs in ref backend for OpenBLAS build * Fixed bugs in ref backend for OpenBLAS build oneapi-src#2 * Reduced header file dependencies in REF backend; removed << operator for RNG (compiling issue) * Update ci.yml * Fixed export on symbols for OpenBLAS build * export.def handling in bazel * Update cpp/daal/src/externals/service_math_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Added libfgortran to REF build * removed config_template auxiliary func * Removed libgfortran for REF backend * Fixed BACKEND incdirs for oneAPI; addressed some comments * Removed unnecessary includes; fixed ifdef in _DECLAR_ files * fixed omitted ifdef in _DECLAR_ files * Clang-format * Clang-format fix * Added an option to move compression to exclude list for examples * Excluded compression examples for all configurations * revert some macros to __intel_compiler * replase some more macros * add NO_FORTRAN=1 to openblas.sh script * Update cpp/daal/src/externals/service_service_ref.h * Fixed missed fpk symbols for oneapi examples (REF backend) * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Update cpp/daal/src/externals/service_service_ref.h Co-authored-by: Pavel Yakovlev <[email protected]> * Fixed error message in oneapi * exclude failed examples with ref backend * exclude examples for oneapi/cpp ifaces * exclude mpi examples for ref backend * Apply suggestions from code review * AVX512_MIC cleanup * Fixed CI pipeline * Added more includes for ONEAPI * Update .ci/pipeline/ci.yml * Switch to core count for blas build * Update .ci/env/openblas.sh * Adding _MKL suffix for job name * Fixing daal4py job dependency * Attempt to fix warnings --------- Co-authored-by: Aleksey Grigorev <[email protected]> Co-authored-by: KulikovNikita <[email protected]> Co-authored-by: a.maklaev <[email protected]> Co-authored-by: Nikolay Petrov <[email protected]> Co-authored-by: Victoriya Fedotova <[email protected]> Co-authored-by: Pavel Yakovlev <[email protected]> Co-authored-by: Pavel Yakovlev <[email protected]>
ahuber21
added a commit
to ahuber21/oneDAL
that referenced
this issue
Oct 19, 2023
ahuber21
added a commit
to ahuber21/oneDAL
that referenced
this issue
Oct 19, 2023
ahuber21
added a commit
that referenced
this issue
Oct 27, 2023
* WIP: Add SHAP contributions and interactions add weights to GbtDecisionTree Include TreeShap recursion steps fix buffer overflow in memcpy Add cover to GbtDecisionTree from model builder fix some index offsets, correct results for trees up to depth=5 fix: nodeIsDummyLeaf is supposed to check left child remove some debug statements chore: apply oneDAL code style predictContribution wrapper with template dispatching increase speed by reducing number of cache misses use thread-local result accessor backup commit with 13% speedup wrt xgboost add preShapContributions/predShapInteractions as function parameter Revert "introduce pred_contribs and pred_interactions SHAP options" This reverts commit 483aa5b. remove some debug content reset env_detect.cpp to origin/master remove std::vector<float> test by introducing thread-local NumericTable Move treeshap into separate translation unit - caution: treeShap undefined in libonedal builds but segfaults Fix function arguments respect predShapContributions and predShapInteractions options and check for legal combinations tmp: work on pred_interactions * no more segfaults * fix pred_interactions * add fast treeshap v1 * Add combinationSum calculation for Fast TreeSHAP v2 * daal_calloc -> daal_malloc * support shap contribution calculation with Fast TreeSHAP v2 * Consistently add cover to daaal APIs, add output parameters to end of function arguments * align tree cfl/reg APIs * restore .gitignore from master * cleanup for review * add newline * remove defaultLeft value that's not needed * Update model builder examples * Add backwards-compatible model builder API & deprecate decls * fix: remove dead code * fix: simplify number of nodes calculation * chore: typos and code style * Fix bazel build * fix: remove dead member variable in GbtDecisionTree * feat: add first unit tests for model builders * revert dal_module back to daal_module * feat: execute dal unit tests in CI * reorganize how tests are executed * add license * Fix new_ts: nodeIsLeaf/nodeIsDummyLeaf internal usage & classification Parameter * Update TreeVisitor with node cover value * remove deprecation version in comment * remove skipping of XGBoost base_score tree * feature: proper support for XGBoost's base_score value * Update code attributions / cite / license * typo * chore: remove resIncrement from GBT predict * Document functions and separate declarations and implementations * review comments #1 * review comments #2 - fix pImpl idiom * refactor: replace boolean parameters with DAAL_UINT64 flag * fix: usage of bias/margin for LightGBM models * review comments #2 * fixup endless for loop * use TArray, introduce TreeShapVersion enum * use TArray where possible * fix: move data field to implementation class * Update cpp/daal/include/algorithms/tree_utils/tree_utils.h Co-authored-by: Victoriya Fedotova <[email protected]> * add typedef to shorten statements * provide doxygen description of gbt classification funtions * fix some typos * consistently use size_t for node indexing; unsigned -> uint32_t * fix: don't include test in release * fix multiline comments --------- Co-authored-by: Victoriya Fedotova <[email protected]> Co-authored-by: Dmitry Razdoburdin <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in the following definition,
template
class DAAL_EXPORT Atomic{
xxx
};
the return type of inc() and dec() should be "dataType" instead of "int"
The text was updated successfully, but these errors were encountered: