Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #1592

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Add files via upload #1592

wants to merge 1 commit into from

Conversation

bjodom
Copy link
Contributor

@bjodom bjodom commented Apr 26, 2023

Existing Sample Changes

Description

These are an update and new addition to the oneAPI samples repo. This is a cleaned up and updated oneMKL example that uses jupyter and demonstrates oneMKL with buffers/accessors, USM, and MPI. While not part of the samples it has been used as an MKL learning path for a year.

Fixes Issue#

External Dependencies

None

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Implement fixes for ONSAM Jiras

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x ] Command Line
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode
  • When compiling the compliler flag "-Wall -Wformat-security -Werror=format-security" was used

@jimmytwei
Copy link
Contributor

Adding @tomlenth @jkinsky
We should have a README.md for this? And should this be in the Libraries folder?

@tomlenth
Copy link
Contributor

tomlenth commented Apr 28, 2023

@jimmytwei yes, it should go into oneMKL and follow a structure that includes the README such as this: sycl-performance-portability-training. This includes supporting files, and naming conventions of both the directory and .py files.

@jkinsky
Copy link
Contributor

jkinsky commented Apr 28, 2023

Yes. We should have a readme for all samples. Tom's suggestions for an example works.

@jkinsky
Copy link
Contributor

jkinsky commented Apr 28, 2023

@jimmytwei and @bjodom - Should this also have a sample.json file?

@jimmytwei
Copy link
Contributor

@jkinsky @bjodom Yes, it should if we want it to be picked up by the samples aggregator and the CI for automated testing.

@jimmytwei
Copy link
Contributor

@jkinsky @bjodom @tomlenth Looking at this again.

@bjodom:

  1. We'll need a sample.json file for this sample.
  2. We'll need a README.md for this sample too.
  3. Based on @tomlenth comment, I think this should go under Libraries/oneMKL instead of Libraries/

Once those are complete, I'll review it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants