-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Events deadlock #226
Events deadlock #226
Conversation
source/layers/validation/checkers/events_deadlock/zel_events_deadlock_checker.h
Outdated
Show resolved
Hide resolved
source/layers/validation/checkers/events_deadlock/zel_events_deadlock_checker.cpp
Outdated
Show resolved
Hide resolved
source/layers/validation/checkers/events_deadlock/zel_events_deadlock_checker.cpp
Outdated
Show resolved
Hide resolved
source/layers/validation/checkers/events_deadlock/zel_events_deadlock_checker.cpp
Outdated
Show resolved
Hide resolved
source/layers/validation/checkers/events_deadlock/zel_events_deadlock_checker.h
Outdated
Show resolved
Hide resolved
source/layers/validation/checkers/events_deadlock/zel_events_deadlock_checker.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the original Apache 2.0 LICENSE file from the XLA project put into the thirdparty/xla folder
00217b0
to
dcaf532
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Licensing perspective this looks good.
You have my informal +1 on License basis...
source/layers/validation/checkers/events_deadlock/zel_events_deadlock_checker.h
Outdated
Show resolved
Hide resolved
source/layers/validation/checkers/events_deadlock/zel_events_deadlock_checker.cpp
Outdated
Show resolved
Hide resolved
9dd299e
to
924a5c8
Compare
Depends on #235 |
02279c9
to
05836ea
Compare
Related-To: NEO-12810 Signed-off-by: Chandio, Bibrak Qamar <[email protected]>
Related-To: NEO-12810 Signed-off-by: Chandio, Bibrak Qamar <[email protected]>
Related-To: NEO-12810 Signed-off-by: Chandio, Bibrak Qamar <[email protected]>
05836ea
to
eb18afc
Compare
@rwmcguir can you sign off if this license is approved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ip+1 < haha, this infrastructure doesn't honor this, but just for fun >
Creates an internal DAG of the events at runtime. From that DAG maintains a topological sort. If there is a cycle in the DAG, adding that dependency in the topological sort will return error hence detecting the deadlock.