Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events deadlock #226

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Events deadlock #226

merged 3 commits into from
Nov 15, 2024

Conversation

bibrak
Copy link
Contributor

@bibrak bibrak commented Oct 30, 2024

Creates an internal DAG of the events at runtime. From that DAG maintains a topological sort. If there is a cycle in the DAG, adding that dependency in the topological sort will return error hence detecting the deadlock.

@bibrak bibrak changed the title Events deadlock [Draft] [RFC] Events deadlock Oct 30, 2024
Copy link
Contributor

@rwmcguir rwmcguir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the original Apache 2.0 LICENSE file from the XLA project put into the thirdparty/xla folder

@bibrak bibrak changed the title [Draft] [RFC] Events deadlock [Draft] Events deadlock Nov 5, 2024
@bibrak bibrak changed the title [Draft] Events deadlock Events deadlock Nov 5, 2024
Copy link
Contributor

@rwmcguir rwmcguir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Licensing perspective this looks good.
You have my informal +1 on License basis...

@bibrak bibrak requested a review from rwmcguir November 12, 2024 17:18
rwmcguir
rwmcguir previously approved these changes Nov 12, 2024
@bibrak bibrak force-pushed the events_deadlock branch 2 times, most recently from 9dd299e to 924a5c8 Compare November 14, 2024 23:03
@nrspruit
Copy link
Contributor

Depends on #235

Related-To: NEO-12810

Signed-off-by: Chandio, Bibrak Qamar <[email protected]>
Related-To: NEO-12810

Signed-off-by: Chandio, Bibrak Qamar <[email protected]>
Related-To: NEO-12810

Signed-off-by: Chandio, Bibrak Qamar <[email protected]>
@nrspruit
Copy link
Contributor

@rwmcguir can you sign off if this license is approved?

Copy link
Contributor

@rwmcguir rwmcguir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ip+1 < haha, this infrastructure doesn't honor this, but just for fun >

@nrspruit nrspruit merged commit 7f6222d into oneapi-src:master Nov 15, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants