abi_fix to be verified #313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there is already a fix for this issue posted here #312 |
bmyates
reviewed
Oct 14, 2024
| objects = sorted(objects, key=lambda obj: (float(obj.get('version',"1.0"))*10000) + int(obj.get('ordinal',"100"))) | ||
| exp_objects = sorted(exp_objects, key=lambda obj: (float(obj.get('version',"1.0"))*10000) + int(obj.get('ordinal',"100"))) | ||
| objects = sorted(objects, key=lambda obj: (float(obj.get('version',"1.0").translate({ord('.'):None}))*10000) + int(obj.get('ordinal',"100"))) | ||
| exp_objects = sorted(exp_objects, key=lambda obj: (float(obj.get('version',"1.0").translate({ord('.'):None}))*10000) + int(obj.get('ordinal',"100"))) |
There was a problem hiding this comment.
would this translate 2.0 -> 20 which would be less than 1.10 -> 110 but greater than 1.1 -> 11
There was a problem hiding this comment.
If at all possible, I highly recommend avoiding anything to do with the Ordinal, it is a mess waiting to happen...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to verify ddi table abi compatibility issue