Skip to content

Commit

Permalink
chore: Fix issue of secrets not working in with block
Browse files Browse the repository at this point in the history
  • Loading branch information
amydoxym committed Dec 3, 2024
1 parent 195f3b8 commit 07b78ab
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,19 +125,23 @@ jobs:
## Deploy to the various clusters
Integration-k8s:
if: github.event.ref == 'refs/heads/develop'
runs-on: ubuntu-latest
needs: [build, sonarcloud]
uses: ./.github/workflows/deploy.yml
with:
environment: "Integration"
secrets:
k8s_url: "${{ secrets.K8S_TEST_URL }}"
k8s_secret: "${{ secrets.K8S_TEST_DEFAULT }}"

QA-k8s:
runs-on: ubuntu-latest
needs: Integration-k8s
if: github.event.ref == 'refs/heads/develop'
uses: ./.github/workflows/deploy.yml
with:
environment: "QA"
secrets:
k8s_url: "${{ secrets.K8S_QA_URL }}"
k8s_secret: "${{ secrets.K8S_QA_DEFAULT }}"

Expand Down
15 changes: 7 additions & 8 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,11 @@ on:
environment:
required: true
type: string
k8s_url:
required: true
type: string
k8s_secret:
required: true
type: string
secrets:
k8s_url:
required: true
k8s_secret:
required: true

jobs:
deploy:
Expand All @@ -27,8 +26,8 @@ jobs:
GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
RUN_ID: "${{ github.run_id }}"
CI_REPOSITORY: "${{ github.repository }}"
K8S_URL: "${{ inputs.k8s_url }}"
K8S_SECRET: "${{ inputs.k8s_secret }}"
K8S_URL: "${{ secrets.k8s_url }}"
K8S_SECRET: "${{ secrets.k8s_secret }}"

- uses: "./.github/actions/helm_fineract_frontend"
with:
Expand Down

0 comments on commit 07b78ab

Please sign in to comment.