File position #67
Merged
File position #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- transformed WriteDot() to (*dotGraph).WriteDot() - transformed render() to (*analysis).Render() - added variable opts *renderOpts to type analysis - transformed analysisSetup() to (*analysis).OptsSetup() - transformed processListArgs to (*analysis).ProcessListARgs() - added (*analysis).OverrideByHTTP() with respective code part from handler.go - transformed doAnalysis() to (*analysis).DoAnalysis() also did some code cleanup and added comments
position of function call in "posCallee" was derived from caller instead of the callee
manipulated dot edge tooltip to display, where a function was called
moved appending of edges from edgeMap right before dotGraph is created reason: edges tooltips need be changed for edge duplicates
tooltip of nodes representing functions is now set explicitly
nodes repressenting functions are now enhanced with the tooltips of the outgoing edges
Co-authored-by: alan <[email protected]>
|
If you could please rebase this on master, I can merge. |
- transformed WriteDot() to (*dotGraph).WriteDot() - transformed render() to (*analysis).Render() - added variable opts *renderOpts to type analysis - transformed analysisSetup() to (*analysis).OptsSetup() - transformed processListArgs to (*analysis).ProcessListARgs() - added (*analysis).OverrideByHTTP() with respective code part from handler.go - transformed doAnalysis() to (*analysis).DoAnalysis() also did some code cleanup and added comments
position of function call in "posCallee" was derived from caller instead of the callee
manipulated dot edge tooltip to display, where a function was called
moved appending of edges from edgeMap right before dotGraph is created reason: edges tooltips need be changed for edge duplicates
tooltip of nodes representing functions is now set explicitly
nodes repressenting functions are now enhanced with the tooltips of the outgoing edges
|
It's done. Hope, it helps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature enhances the edge discription in the resulting dot graph and svg outputs.
The enhancement also apply to anonymous functions: If an anonymous function is assigned to a variable, the line position of the call to that variable is displayed as the call to the anonymous function.