removed unnecessary condition from gh action

onderonur · Aug 18, 2024 · 0d62688 · 0d62688
1 parent 6b0ee9e
commit 0d62688
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/.github/composite-actions/install/action.yml b/.github/composite-actions/install/action.yml
@@ -7,7 +7,7 @@ runs:
     - name: Setup Node.js
       uses: actions/setup-node@v4
       with:
-        node-version: 20
+        node-version-file: '.nvmrc'
         cache: npm
 
     - name: Install dependencies

diff --git a/.github/workflows/nextjs.yml b/.github/workflows/nextjs.yml
@@ -52,11 +52,6 @@ jobs:
 
   # Deployment job
   deploy:
-    # Since `workflow_run` only has 3 activity types (`completed`, `requested` and `in_progress`),
-    # even if `Quality` workflow gets completed by failing, this workflow starts to run.
-    # To prevent this, we add a condition here.
-    # https://github.com/orgs/community/discussions/26238#discussioncomment-3250901
-    if: ${{ github.event.workflow_run.conclusion == 'success' }}
     environment:
       name: github-pages
       url: ${{ steps.deployment.outputs.page_url }}